Filter SDK-generated friend assembly attributes - #2825
Merged
Conversation
added 2 commits
July 27, 2026 21:39
Emit InternalsVisibleTo annotations only for attributes backed by translated source documents, leaving SDK-generated obj AssemblyInfo attributes to the preserved MSBuild items. Verify SDK and hand-authored declarations each appear once in compiled metadata.
Keep hand-authored InternalsVisibleTo annotations in translated source, preserve SDK-generated declarations only for diagnostic projects, and reproduce generated friend items in repository test parity projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InternalsVisibleToattributes by source provenance before emittingAssemblyInfo.gsobjassembly attributes already reproduced from preserved MSBuild itemsTests
dotnet test tools/cs2gs/Cs2Gs.Tests/Cs2Gs.Tests.csproj --filter FullyQualifiedName~Cs2Gs.Tests.MigrationPipelineTests --no-restore --verbosity minimal(12 passed)dotnet test tools/cs2gs/Cs2Gs.Tests/Cs2Gs.Tests.csproj --no-build --no-restore --verbosity minimal(1788 passed)Fixes #2816