Improve specs #998
Merged
Improve specs #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves test specifications by ensuring consistency between validator attribute declarations and their corresponding client_side_hash method calls. Previously, tests were using mismatched attributes (e.g., initializing validators with :name but calling methods with :age), which didn't cause failures because the attribute parameter was only used for fetching custom messages.
- Replaced non-existent
:nameattributes with the actual:first_nameattribute from the Person model - Aligned validator attribute parameters with the attribute passed to
client_side_hashcalls - Updated expected messages in confirmation validator tests to reflect the correct attribute name
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/active_model/cases/test_presence_validator.rb | Changed :name to :first_name to match actual Person model attributes and ensure consistency between validator initialization and method calls |
| test/active_model/cases/test_length_validator.rb | Corrected second parameter from :first_name to :age to match the validator's attribute configuration |
| test/active_model/cases/test_inclusion_validator.rb | Changed :name to :first_name throughout to use actual Person model attributes |
| test/active_model/cases/test_format_validator.rb | Changed :name to :first_name throughout to use actual Person model attributes |
| test/active_model/cases/test_exclusion_validator.rb | Changed :name to :first_name throughout to use actual Person model attributes |
| test/active_model/cases/test_confirmation_validator.rb | Changed :name to :first_name and updated expected messages from "Age" to "First name" to reflect the correct attribute being validated |
| test/active_model/cases/test_acceptance_validator.rb | Changed :name to :first_name to use actual Person model attributes |
| test/active_model/cases/test_absence_validator.rb | Changed :name to :first_name to use actual Person model attributes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tagliala
force-pushed
the
chore/improve-specs
branch
from
07d8b3a to
4e6030f
Compare
Use real attributes and match attribute name when getting client side hash. Since that attribute is only used to fetch a custom message, specs weren't failing before Additionally: - Do not test Rails edge against 3.2, because it now requires >= 3.3 - Do not test Ruby edge against Rails < 8.0
tagliala
force-pushed
the
chore/improve-specs
branch
from
4e6030f to
3476ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use real attributes and match attribute name when getting client side hash.
Since that attribute is only used to fetch a custom message, specs weren't failing before