Skip to content

Bug/fix locked param sliders #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeDuckProject merged 3 commits into from
Jun 20, 2025
Merged

Bug/fix locked param sliders #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
663658f
Fixed other tests (they were spec and didn't run)
DeDuckProject Jun 20, 2025
a6d7986
fixed slider locked by fixing generation script
DeDuckProject Jun 20, 2025
6ddbad6
moved plotMeta to gitignore since its auto-generated
DeDuckProject Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ dist-ssr
*.sw?

scripts/generatePlotMeta*.js
scripts/generatePlotMeta*.mjs
scripts/generatePlotMeta*.mjs
src/data/plotMeta.ts
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"build:meta": "tsx scripts/generatePlotMeta.ts",
"lint": "eslint .",
"preview": "vite preview",
"test": "vitest run"
"test": "npm run build:meta && vitest run"
},
"dependencies": {
"@hookform/resolvers": "^3.9.0",
Expand Down
13 changes: 6 additions & 7 deletions scripts/generatePlotMeta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,12 @@ const PLOT_TYPE_MAPPING: Record<string, string> = {

// Dependency matrix from requirements
export const DEPENDENCY_MATRIX: Record<string, Record<keyof PlotParams, boolean>> = {
'3D global-schedule': { eta_c: true, epsilon_G: true, N: true, M: true, rule: true },
'Best strategies 2D': { eta_c: true, epsilon_G: true, N: true, M: true, rule: false },
'SKR vs F_th': { eta_c: true, epsilon_G: true, N: true, M: true, rule: false },
'Advantage heatmaps': { eta_c: true, epsilon_G: true, N: false, M: false, rule: true },
'Plateau grid': { eta_c: false, epsilon_G: false, N: false, M: false, rule: false },
// 'Threshold heatmap': { eta_c: false, epsilon_G: false, N: false, M: true, rule: false },
'BSA Coupling Efficiency comparisons': { eta_c: false, epsilon_G: true, N: true, M: true, rule: true } // TODO decide if to remove later (see task014.md)
'3D local vs. global schedule': { eta_c: true, epsilon_G: true, N: true, M: true, rule: true },
'Policy comparison': { eta_c: true, epsilon_G: true, N: true, M: true, rule: false },
'Policy comparison (only local)': { eta_c: true, epsilon_G: true, N: true, M: true, rule: false },
'Distance gain heatmap': { eta_c: true, epsilon_G: true, N: false, M: false, rule: true },
'Inverse plateau ratio LD/GD': { eta_c: false, epsilon_G: false, N: false, M: false, rule: false },
'BSA Coupling Efficiency comparison': { eta_c: false, epsilon_G: true, N: true, M: true, rule: true }
};

export function parseEtaC(dirname: string): EtaC | undefined {
Expand Down
Loading