Php parser adapter #7
Conversation
Implements a class dependency analyzer using the PHP-Parser library. This allows for static analysis of PHP code to determine class dependencies, interfaces, and abstract classes. The implementation provides an adapter that conforms to the ClassDependenciesParser interface, enabling a flexible and extensible architecture. It also adds an AGENTS.md file that explains how agents should operate within the codebase.
Improves the analysis of PHP classes by adding support for modern syntax features (PHP 8.1+), including enums, readonly properties, attributes and interface analysis within classes. The update ensures accurate identification of class dependencies and correct flagging of abstract/interface status when modern syntax is used.
|
Warning Rate limit exceeded@DeGraciaMathieu has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughCes modifications introduisent une nouvelle infrastructure d'analyse de dépendances de classes PHP basée sur PhpParser. Le changement inclut quatre fichiers de code principaux : une classe de données (AstClassAnalysis), un visiteur AST (DependencyCollectorVisitor), un analyseur principal (PhpAstClassDependenciesParser) implémentant l'interface ClassDependenciesParser, ainsi qu'un fichier fixture et des tests unitaires correspondants. Une documentation AGENTS.md est également ajoutée pour les assistants de codage. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Extends the testing matrix to include PHP 8.5. This ensures compatibility and reduces the risk of regressions with the latest PHP version.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Fix all issues with AI Agents 🤖
In
@app/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.php:
- Around line 35-37: DependencyCollectorVisitor currently collects every
Node\Name which yields many false positives; update the logic that adds
$node->toString() so it only records names when the parent node context
represents a real dependency: check $node->getAttribute('parent') and allow
adding only when parent is one of Class_::extends, Class_::implements,
Interface_::extends, FunctionLike/Param::type, FunctionLike::returnType,
Expr\New_, Expr\Instanceof_, Stmt\Catch_, or Node\Attribute (and similar
type/attribute positions); additionally ignore built-in/primitive type names and
special names (self, static, parent) and PHP internal classes, then keep
array_unique() for deduplication. Locate and change the conditional around the
Node\Name handling in DependencyCollectorVisitor to perform these context and
name checks before pushing to $this->dependencies.
In
@app/Infrastructure/Analyze/Adapters/PhpParser/PhpAstClassDependenciesParser.php:
- Line 15: file_get_contents($file) can return false and the code later passes
$code into parse(), causing a type error; update the
PhpAstClassDependenciesParser code to check the result of
file_get_contents($file) (the $code variable) and handle failures explicitly: if
it === false, throw a clear exception or return a controlled error/log message
including the $file path and errno/reason, otherwise continue to call parse()
with the valid string; locate the file_get_contents call and the surrounding
parse() usage in the parse method of PhpAstClassDependenciesParser to implement
this check.
In @tests/Fixtures/Php85/ModernClass.php:
- Around line 27-30: The method handle(Status|Contract|null $value):
?DateTimeInterface declares a parameter $value that is never used; either remove
$value from the handle signature if it isn’t needed for the fixture, or use
$value inside handle (e.g., read a property or branch on its type) to make its
presence meaningful; update any related tests/fixtures to match the changed
signature and ensure ModernClass::handle remains consistent with the intended
union-type demonstration.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
AGENTS.mdapp/Infrastructure/Analyze/Adapters/PhpParser/AstClassAnalysis.phpapp/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.phpapp/Infrastructure/Analyze/Adapters/PhpParser/PhpAstClassDependenciesParser.phptests/Fixtures/Php85/ModernClass.phptests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.php
🧰 Additional context used
🧬 Code graph analysis (3)
app/Infrastructure/Analyze/Adapters/PhpParser/PhpAstClassDependenciesParser.php (2)
app/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.php (2)
DependencyCollectorVisitor(11-53)analysis(44-52)app/Infrastructure/Analyze/Adapters/Jerowork/ClassDependenciesParserAdapter.php (1)
traverse(51-56)
app/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.php (1)
app/Infrastructure/Analyze/Adapters/PhpParser/AstClassAnalysis.php (5)
dependencies(21-24)fqcn(16-19)isInterface(26-29)isAbstract(31-34)AstClassAnalysis(7-35)
tests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.php (2)
app/Infrastructure/Analyze/Adapters/PhpParser/PhpAstClassDependenciesParser.php (1)
PhpAstClassDependenciesParser(11-29)app/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.php (1)
analysis(44-52)
🪛 PHPMD (2.15.0)
tests/Fixtures/Php85/ModernClass.php
27-27: Avoid unused parameters such as '$value'. (undefined)
(UnusedFormalParameter)
🔇 Additional comments (2)
app/Infrastructure/Analyze/Adapters/PhpParser/PhpAstClassDependenciesParser.php (1)
18-18: Le commentaire est inexact :parse()ne retourne pas null avec la configuration par défautLa méthode
parse()retournenulluniquement lorsqu'un ErrorHandler non-throwing est explicitement configuré. Ici,ParserFactory::createForNewestSupportedVersion()utilise l'ErrorHandler par défaut (Throwing), qui lève une exception en cas d'erreur de parsing, sans retourner null. Aucune vérification de null n'est nécessaire à la ligne 18.Likely an incorrect or invalid review comment.
tests/Fixtures/Php85/ModernClass.php (1)
1-24: Structure appropriée pour une fixture de test.Les définitions sont claires et couvrent bien les fonctionnalités PHP modernes (attributs, enum, readonly properties). La fixture servira bien les tests du parser.
| if ($node instanceof Node\Name) { | ||
| $this->dependencies[] = $node->toString(); | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's look at the file structure and the actual implementation
cat -n app/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.php | head -60Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1993
🏁 Script executed:
# Search for other implementations of dependency analysis or visitor patterns
fd DependencyCollector --type f | head -20Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 167
🏁 Script executed:
# Look for how the visitor is used and initialized
rg -n "DependencyCollectorVisitor" --type=php | head -20Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 375
🏁 Script executed:
# Check if there are parent node tracking or context filtering mechanisms
rg -n "getAttribute.*parent|parent.*getAttribute" --type=php | head -15Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 73
🏁 Script executed:
# Search for other visitor implementations to understand the pattern
ast-grep --pattern 'class $_ extends NodeVisitor {
$$$
}'Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 73
🏁 Script executed:
# Search for tests related to DependencyCollectorVisitor
fd -e "test" -o -name "*Test*" --type f | xargs rg -l "DependencyCollectorVisitor" 2>/dev/null || echo "No direct test references found"Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 495
🏁 Script executed:
# Look for test files in common locations
fd ".*Test\.php" --type f | head -20Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 953
🏁 Script executed:
# Check the PhpAstClassDependenciesParser to understand context
cat -n app/Infrastructure/Analyze/Adapters/PhpParser/PhpAstClassDependenciesParser.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1147
🏁 Script executed:
# Look for examples or documentation about what dependencies should be collected
rg -n "dependencies|class.*dependency" --type=php -i | head -30Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 3949
🏁 Script executed:
# Check if there are functional tests or examples
fd -e "php" --type f | xargs rg -l "DependencyCollector|dependencies" | head -10Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 583
🏁 Script executed:
# Look at the entire visitor pattern in use
rg -n -B5 -A10 "new DependencyCollectorVisitor" --type=phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1771
🏁 Script executed:
cat -n tests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1352
🏁 Script executed:
# Look for test fixtures that show example code being parsed
fd "Fixtures\|fixtures" -i --type f | head -10Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 73
🏁 Script executed:
# Check what the actual dependencies should be
rg -A20 "detects dependencies from modern PHP syntax" tests/Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 2365
🏁 Script executed:
cat -n tests/Fixtures/Php85/ModernClass.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1013
🏁 Script executed:
# Look for function names, constants, or other names that might be false positives
rg "function|const " tests/Fixtures/Php85/ModernClass.php -nRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 256
🏁 Script executed:
# Search for more test fixtures to see edge cases
fd "\.php" tests/Fixtures/ --type f | head -20Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 127
🏁 Script executed:
# Search for other test fixtures with more complex code patterns
find tests/Fixtures -name "*.php" -type f | xargs wc -l | sort -rn | head -10Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 130
🏁 Script executed:
# Look for any tests that might show what should NOT be captured
rg "should.*not|must.*not|must.*exclude" tests/ -iRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 332
🏁 Script executed:
# Check if there are function calls or constants in other fixtures that might be false positives
find tests/Fixtures -name "*.php" -type f -exec grep -l "function\|const\|::" {} \;Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 127
🏁 Script executed:
# Examine the NameResolver behavior in PHP Parser documentation or usage
rg "NameResolver" --type=php -B2 -A2Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1280
🏁 Script executed:
# Check if there are any fixtures with function calls or constants that might be captured as false positives
find tests/Fixtures -name "*.php" -exec grep -H "function \|const \|::\|new " {} \; 2>/dev/null | head -20Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 434
🏁 Script executed:
# Create a test case to see what Node\Name captures with function calls
cat > /tmp/test_parser.php << 'EOF'
<?php
namespace Tests;
use SomeClass;
class MyClass extends SomeClass {
public function myFunc(OtherClass $param): ResultClass {
callFunction();
SOME_CONSTANT;
new AnotherClass();
return $param;
}
}
EOF
cd /tmp && php -r "
require '/repo/vendor/autoload.php';
use PhpParser\ParserFactory;
use PhpParser\NodeTraverser;
use PhpParser\NodeVisitor\NameResolver;
use PhpParser\Node;
class DebugVisitor extends \PhpParser\NodeVisitorAbstract {
public function enterNode(Node \$node) {
if (\$node instanceof Node\Name) {
echo 'Node\\Name: ' . \$node->toString() . ' (type: ' . \$node->getType() . ')' . PHP_EOL;
}
}
}
\$code = file_get_contents('/tmp/test_parser.php');
\$parser = (new ParserFactory())->createForNewestSupportedVersion();
\$ast = \$parser->parse(\$code);
\$traverser = new NodeTraverser();
\$traverser->addVisitor(new NameResolver());
\$traverser->addVisitor(new DebugVisitor());
\$traverser->traverse(\$ast);
" 2>&1 || echo "Test execution had issues"Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 452
🏁 Script executed:
# Check the actual PHP Parser documentation for Node\Name behavior
# Look at how the parser represents different name contexts
rg "Node\\\\Name" --type=php -B2 -A2 | head -40Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1121
🏁 Script executed:
# Check what types of values are in the dependencies in actual test run
# Look for constant names, builtin type names that might be captured
rg "null|true|false|int|string|bool" tests/Fixtures/Php85/ModernClass.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 210
🏁 Script executed:
# Search for any documentation or comments about Node\Name in the codebase
rg "Node.*Name|dependency.*context" --type=php -B1 -A1 | head -30Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 3314
🏁 Script executed:
# Check if there are integration tests that show actual output
find tests -name "*.php" -exec grep -l "dependencies()" {} \; | xargs grep -A5 "dependencies()"Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1603
🏁 Script executed:
# Let me check what the actual test expects - does toContain mean other values are allowed?
# Run the test to see if it passes and what the actual output is
grep -A30 "toContain" tests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 752
🏁 Script executed:
# Check if there's a test case with actual function calls
fd "\.php" tests/Fixtures -exec grep -l "function\|::" {} \;Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 297
🏁 Script executed:
# Look for any additional test fixtures or edge cases
ls -la tests/Fixtures/Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 253
🏁 Script executed:
# Check if 'null' keyword appears in actual dependencies (which would be a false positive from union types)
rg "null|true|false" tests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 73
🏁 Script executed:
# Check the full analyzer flow to see if filtering happens elsewhere
rg "dependencies.*filter|filter.*dependencies" --type=php -iRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 73
🏁 Script executed:
# Let me understand PHP parser structure better - check what type of node represents function calls
rg "Node\\\\" --type=php | grep -i "call\|const\|function" | head -20Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 73
🏁 Script executed:
# Check the Jerowork adapter which seems to have more sophisticated filtering
cat -n app/Infrastructure/Analyze/Adapters/Jerowork/NativeDecliner.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1709
🏁 Script executed:
# Look at what other adapters exist and how they handle dependencies
fd ".*Decliner\.php|.*Processor\.php" --type f app/Infrastructure/Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 154
🏁 Script executed:
# Let me check if there's a way to see what dependencies() actually returns
# Look for any test that checks the exact list or checks for unwanted items
grep -r "dependencies()" tests/Unit/Infrastructure/Analyze/ -A10 -B2Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1455
🏁 Script executed:
# Check if the tool filters out primitives somewhere
rg "string|int|bool|null|void|mixed" app/Infrastructure/Analyze/Adapters/PhpParser/ --type=phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1494
🏁 Script executed:
# Search for where dependencies are used after being collected
rg "->dependencies()" app/ --type=php -B2 -A2 | head -40Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 495
🏁 Script executed:
# Check if there's any documentation or comments explaining the expected behavior
rg "dependency|collect" app/Infrastructure/Analyze/ --type=php -i -B1 -A1 | head -50Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 4743
🏁 Script executed:
# Let's check if php parser represents null, string, etc as Node\Name
# by looking at PHP Parser source or documentation in vendor
find vendor -path "*php-parser*" -name "*.md" -o -name "README*" 2>/dev/null | head -5Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 73
🏁 Script executed:
# Check what actually gets collected - run a deeper analysis
# Look for any place where dependencies are checked for validity
rg "array_unique|dependencies\[\]" app/Infrastructure/Analyze/ --type=php -B2 -A2Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1641
🏁 Script executed:
# Check if there are any filtering mechanisms AFTER collection
rg "in_array|array_filter|array_diff" app/Infrastructure/Analyze/ --type=phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 364
🏁 Script executed:
# Most importantly - let me see what primitives or keywords might be captured
cat app/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.php | grep -A20 "enterNode"Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 747
🏁 Script executed:
# Check if the test actually verifies all dependencies, not just a subset
grep -B5 -A15 "toContain" tests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 811
🏁 Script executed:
# Let me verify if Node\Name captures function names
# Look for examples with function calls in test fixtures or codebase
find . -name "*.php" -type f -exec grep -l "function.*(" {} \; 2>/dev/null | grep -i test | head -5Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 303
🏁 Script executed:
# Check if there are any integration tests with more complex code
find tests -name "*.php" -type f | xargs wc -l | sort -rn | head -10Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 565
🏁 Script executed:
# Let me look at what PHP Parser documentation says about Node\Name
# by checking if there's any inline documentation
grep -r "Node\\\\Name" . --include="*.php" -B2 -A2 | head -40Repository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1141
🏁 Script executed:
# The key question: does the test actually verify NO other dependencies exist?
# Or just that these 8 are present?
grep -B2 -A20 "it('detects dependencies" tests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 935
🏁 Script executed:
# Create a simple test to understand PHP Parser's behavior with function calls
python3 << 'PYTHON'
# Check PHP Parser source or documentation structure
import subprocess
import os
# Look for PHP Parser files in vendor
result = subprocess.run(['find', 'vendor/nikic/php-parser', '-name', '*.php', '-path', '*/Node*'],
capture_output=True, text=True)
files = result.stdout.strip().split('\n')
php_parser_nodes = [f for f in files if 'Name' in f][:10]
for f in php_parser_nodes:
print(f)
PYTHONRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 177
🏁 Script executed:
# Final verification - check the complete test to see if it verifies exact dependencies
cat tests/Unit/Infrastructure/Analyze/PhpAstClassDependenciesParserTest.phpRepository: DeGraciaMathieu/php-class-dependencies-analyzer
Length of output: 1135
Collecter sélectivement selon le contexte du nœud parent
La capture de tous les Node\Name sans filtrage entraîne la collecte de noms non pertinents. Le codebase contient une alternative (adapter Jerowork) qui filtre explicitement les types primitifs (null, string, int, bool, etc.) et les classes/fonctions natives PHP, confirmant que ce risque est réel.
Actuellement, array_unique() ne déduplique que ; il n'élimine pas les faux positifs sémantiques. Le test utilise toContain() plutôt que toBe(), ce qui permet des dépendances supplémentaires non détectées.
Considérez un filtrage par contexte parent pour capturer uniquement les dépendances de classe valides : extends, implements, type hints, new, instanceof, catch, attributes.
🤖 Prompt for AI Agents
In @app/Infrastructure/Analyze/Adapters/PhpParser/DependencyCollectorVisitor.php
around lines 35-37, DependencyCollectorVisitor currently collects every
Node\Name which yields many false positives; update the logic that adds
$node->toString() so it only records names when the parent node context
represents a real dependency: check $node->getAttribute('parent') and allow
adding only when parent is one of Class_::extends, Class_::implements,
Interface_::extends, FunctionLike/Param::type, FunctionLike::returnType,
Expr\New_, Expr\Instanceof_, Stmt\Catch_, or Node\Attribute (and similar
type/attribute positions); additionally ignore built-in/primitive type names and
special names (self, static, parent) and PHP internal classes, then keep
array_unique() for deduplication. Locate and change the conditional around the
Node\Name handling in DependencyCollectorVisitor to perform these context and
name checks before pushing to $this->dependencies.
| { | ||
| public function parse(string $file): ClassAnalysis | ||
| { | ||
| $code = file_get_contents($file); |
There was a problem hiding this comment.
Gestion d'erreur manquante pour la lecture de fichier
file_get_contents() retourne false en cas d'échec (fichier introuvable, permissions insuffisantes, etc.), ce qui causera une erreur de type à la ligne 18 lorsque false sera passé à parse().
🔎 Solution proposée avec gestion d'erreur
+$code = @file_get_contents($file);
+
+if ($code === false) {
+ throw new \RuntimeException("Impossible de lire le fichier : {$file}");
+}
-$code = file_get_contents($file);Alternative sans opérateur @ :
+if (!file_exists($file)) {
+ throw new \RuntimeException("Fichier introuvable : {$file}");
+}
+
+if (!is_readable($file)) {
+ throw new \RuntimeException("Fichier non lisible : {$file}");
+}
+
$code = file_get_contents($file);
+
+if ($code === false) {
+ throw new \RuntimeException("Erreur lors de la lecture du fichier : {$file}");
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| $code = file_get_contents($file); | |
| $code = @file_get_contents($file); | |
| if ($code === false) { | |
| throw new \RuntimeException("Impossible de lire le fichier : {$file}"); | |
| } |
| $code = file_get_contents($file); | |
| if (!file_exists($file)) { | |
| throw new \RuntimeException("Fichier introuvable : {$file}"); | |
| } | |
| if (!is_readable($file)) { | |
| throw new \RuntimeException("Fichier non lisible : {$file}"); | |
| } | |
| $code = file_get_contents($file); | |
| if ($code === false) { | |
| throw new \RuntimeException("Erreur lors de la lecture du fichier : {$file}"); | |
| } |
🤖 Prompt for AI Agents
In
@app/Infrastructure/Analyze/Adapters/PhpParser/PhpAstClassDependenciesParser.php
around line 15, file_get_contents($file) can return false and the code later
passes $code into parse(), causing a type error; update the
PhpAstClassDependenciesParser code to check the result of
file_get_contents($file) (the $code variable) and handle failures explicitly: if
it === false, throw a clear exception or return a controlled error/log message
including the $file path and errno/reason, otherwise continue to call parse()
with the valid string; locate the file_get_contents call and the surrounding
parse() usage in the parse method of PhpAstClassDependenciesParser to implement
this check.
| public function handle(Status|Contract|null $value): ?DateTimeInterface | ||
| { | ||
| return $this->clock; | ||
| } |
There was a problem hiding this comment.
Paramètre inutilisé dans la méthode handle().
Le paramètre $value est déclaré mais jamais utilisé dans le corps de la méthode. Même dans une fixture de test, cela peut prêter à confusion.
🔎 Correction proposée
Si le paramètre est nécessaire uniquement pour tester la détection des types union, considère soit :
- L'utiliser dans le corps de la méthode
- Le supprimer si non nécessaire
#[CustomAttribute]
- public function handle(Status|Contract|null $value): ?DateTimeInterface
+ public function handle(): ?DateTimeInterface
{
return $this->clock;
}Ou si tu veux démontrer la gestion des types union :
#[CustomAttribute]
public function handle(Status|Contract|null $value): ?DateTimeInterface
{
+ // Utilisation du paramètre pour démonstration
+ if ($value instanceof Status) {
+ return $this->clock;
+ }
return $this->clock;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| public function handle(Status|Contract|null $value): ?DateTimeInterface | |
| { | |
| return $this->clock; | |
| } | |
| #[CustomAttribute] | |
| public function handle(): ?DateTimeInterface | |
| { | |
| return $this->clock; | |
| } |
🧰 Tools
🪛 PHPMD (2.15.0)
27-27: Avoid unused parameters such as '$value'. (undefined)
(UnusedFormalParameter)
🤖 Prompt for AI Agents
In @tests/Fixtures/Php85/ModernClass.php around lines 27-30, The method
handle(Status|Contract|null $value): ?DateTimeInterface declares a parameter
$value that is never used; either remove $value from the handle signature if it
isn’t needed for the fixture, or use $value inside handle (e.g., read a property
or branch on its type) to make its presence meaningful; update any related
tests/fixtures to match the changed signature and ensure ModernClass::handle
remains consistent with the intended union-type demonstration.
Prevents built-in PHP types from being incorrectly identified as dependencies. This change improves the accuracy of dependency analysis by filtering out types like `string`, `int`, `array`, etc., ensuring that only actual project dependencies are included in the results.
PHP 8.5 is not yet released, so remove it from the testing matrix. This prevents errors in the build process due to the non-existent PHP version.
No description provided.