Allow Infinity and NaN in JSON parsing#13
Merged
DePasqualeOrg merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
Add YYJSON_READ_ALLOW_INF_AND_NAN flag to both YYJSONParser.parseToConfig overloads. Upstream only had one call site; our fork has a second overload that also needed the flag. Cherry-picked from huggingface/swift-transformers#324 (150169b). Co-Authored-By: Anthony DePasquale <anthony@depasquale.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of upstream #324.
Problem
Some model configs (e.g.,
mlx-community/NVIDIA-Nemotron-3-Nano-30B-A3B-4bit) containInfinity,-Infinity, orNaNvalues in their JSON. The YYJSON parser rejected these as invalid, causing config loading to fail.Fix
Pass
YYJSON_READ_ALLOW_INF_AND_NANflag toyyjson_read_opts. Our fork has twoparseToConfigoverloads (upstream only has one), so the flag was applied to both.Skipped the upstream
Tests/HubTeststest (out of scope for our fork).