Rename tokens to tokenIds for [Int] parameters#14
Merged
DePasqualeOrg merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokenshas been renamed totokenIdsin all parameters and local bindings where the type is[Int](integer IDs), aligning with the naming convention in Python'stransformers.Python
transformersconsistently distinguishes "tokens" (string representations) from "token_ids" (integer representations). Thedecodemethod in Python usestoken_idsas its parameter name. This package previously useddecode(tokens: [Int]), which was inconsistent.Changes
Protocol requirement (
Tokenizer):decode(tokens:skipSpecialTokens:)->decode(tokenIds:skipSpecialTokens:)Protocol extension (
Tokenizer):decode(tokens:)->decode(tokenIds:)PreTrainedTokenizer:decode(tokens:skipSpecialTokens:)->decode(tokenIds:skipSpecialTokens:)BertTokenizer:decode(tokens:)->decode(tokenIds:)unTokenize(tokens:)->unTokenize(tokenIds:)(internal)Not changed:
Decoder.decode(tokens: [String])and related code, where "tokens" correctly refers to string tokens.Breaking change
This is a source-breaking change for any code calling
decode(tokens:)ordecode(tokens:skipSpecialTokens:). The fix is a straightforward rename at call sites.