-
Notifications
You must be signed in to change notification settings - Fork 74
Merge pull request #138 from Ahbiz/feature/issue-132 unified saved hub and bookmark refactor (Closes #132) #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
04ba008
feat(pwa): add offline support and installable PWA with Serwist
abimbolaalabi c45fccd
fix: add --legacy-peer-deps to CI and sync lockfile
abimbolaalabi eb410d2
Merge pull request #111 from abimbolaalabi/feat/enhancement-progressive
zeemscript 14ccd29
docs(readme): add live application screenshots
abimbolaalabi 37c25df
Merge pull request #112 from abimbolaalabi/replace-placeholder
zeemscript 918862d
feat(dashboard): add educator earnings analytics dashboard
IamOluwatoyin 7db4b0d
Merge pull request #136 from IamOluwatoyin/features/educator-dashboar…
zeemscript 2bf7cc3
unified saved hub and bookmark refactor (Closes #132)
Ahbiz 036a014
added prayer times and Hijri date widget to dashboard (Closes #133)
Ahbiz 5d9601e
fix: restore optimistically removed items on rollback and guard stale…
Ahbiz c49b1f5
fix: address CodeRabbit review feedback for prayer times widget
Ahbiz 1be9b57
feat(purchases): add My Purchases library with Stellar payment receipts
IamOluwatoyin 8443492
Merge branch 'dev' into features/my-purchases-library
IamOluwatoyin 92ef962
fix: add trailing comma to ShoppingBag import in nav-routers
IamOluwatoyin c35d30a
Merge pull request #140 from IamOluwatoyin/features/my-purchases-library
zeemscript 8a24dde
Merge pull request #139 from Ahbiz/feature/issue-133
zeemscript 48767c6
chore: resolve merge conflict with upstream/dev in nav-routers.jsx an…
Ahbiz f8edf20
Merge pull request #138 from Ahbiz/feature/issue-132
zeemscript File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| legacy-peer-deps=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Install banner becomes a dead end after the user dismisses the native prompt.
installableonly resets tofalseon"accepted". On dismiss,deferredPromptis cleared but the banner (which gates oninstallable) stays visible — clicking "Install" again then silently no-ops sincehandleInstallearly-returns whendeferredPromptis null.🐛 Proposed fix
const handleInstall = async () => { if (!deferredPrompt) return; deferredPrompt.prompt(); const result = await deferredPrompt.userChoice; - if (result.outcome === "accepted") { - setInstallable(false); - } + setInstallable(false); setDeferredPrompt(null); };📝 Committable suggestion
🤖 Prompt for AI Agents