Skip to content

remove unreachable exchange code + support replace view #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canbekley wants to merge 2 commits into from
Closed

remove unreachable exchange code + support replace view #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d55881b
remove unreachable exchange code + support replace view
BentsiLeviav Feb 4, 2025
27c227c
revert get_model_settings change
canbekley Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 14 additions & 45 deletions dbt/include/clickhouse/macros/materializations/view.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,52 +2,24 @@

{%- set existing_relation = load_cached_relation(this) -%}
{%- set target_relation = this.incorporate(type='view') -%}
{%- set backup_relation = none -%}
{%- set preexisting_backup_relation = none -%}
{%- set preexisting_intermediate_relation = none -%}

{% if existing_relation is not none %}
{%- set backup_relation_type = existing_relation.type -%}
{%- set backup_relation = make_backup_relation(target_relation, backup_relation_type) -%}
{%- set preexisting_backup_relation = load_cached_relation(backup_relation) -%}
{% if not existing_relation.can_exchange %}
{%- set intermediate_relation = make_intermediate_relation(target_relation) -%}
{%- set preexisting_intermediate_relation = load_cached_relation(intermediate_relation) -%}
{% endif %}
{% endif %}

{% set grant_config = config.get('grants') %}

{{ run_hooks(pre_hooks, inside_transaction=False) }}

-- drop the temp relations if they exist already in the database
{{ drop_relation_if_exists(preexisting_intermediate_relation) }}
{{ drop_relation_if_exists(preexisting_backup_relation) }}

-- `BEGIN` happens here:
{{ run_hooks(pre_hooks, inside_transaction=True) }}

{% if backup_relation is none %}
{% if existing_relation is none %}
{{ log('Creating new relation ' + target_relation.name )}}
-- There is not existing relation, so we can just create
{% call statement('main') -%}
{{ get_create_view_as_sql(target_relation, sql) }}
{%- endcall %}
{% elif existing_relation.can_exchange %}
-- We can do an atomic exchange, so no need for an intermediate
{% call statement('main') -%}
{{ get_create_view_as_sql(backup_relation, sql) }}
{%- endcall %}
{% do exchange_tables_atomic(backup_relation, existing_relation) %}
{% else %}
-- We have to use an intermediate and rename accordingly
{% call statement('main') -%}
{{ get_create_view_as_sql(intermediate_relation, sql) }}
{%- endcall %}
{{ adapter.rename_relation(existing_relation, backup_relation) }}
{{ adapter.rename_relation(intermediate_relation, target_relation) }}
{{ log('Relation ' + target_relation.name + ' already exists, replacing it' )}}
{% endif %}

{% call statement('main') -%}
{{ get_create_view_as_sql(target_relation, sql) }}
{%- endcall %}

-- cleanup
{% set should_revoke = should_revoke(existing_relation, full_refresh_mode=True) %}
{% do apply_grants(target_relation, grant_config, should_revoke=should_revoke) %}
Expand All @@ -58,8 +30,6 @@

{{ adapter.commit() }}

{{ drop_relation_if_exists(backup_relation) }}

{{ run_hooks(post_hooks, inside_transaction=False) }}

{{ return({'relations': [target_relation]}) }}
Expand All @@ -70,20 +40,19 @@
{% macro clickhouse__create_view_as(relation, sql) -%}
{%- set sql_header = config.get('sql_header', none) -%}
{{ sql_header if sql_header is not none }}
create view {{ relation.include(database=False) }} {{ on_cluster_clause(relation)}} as (

create or replace view {{ relation.include(database=False) }} {{ on_cluster_clause(relation)}}
{% set contract_config = config.get('contract') %}
{% if contract_config.enforced %}
{{ get_assert_columns_equivalent(sql) }}
{%- endif %}
{% if sql is none %}
{{clickhouse__create_select_query_from_schema()}}
{%- else -%}
{{ sql }}
{%- endif -%}
as (
{{ sql }}
{{ adapter.get_model_query_settings(model) }}
)
{% if model.get('config').get('materialized') == 'view' %}
{{ adapter.get_model_settings(model) }}
{%- endif %}
{% if model.get('config').get('materialized') == 'view' %}
{{ adapter.get_model_settings(model) }}
{%- endif %}

{%- endmacro %}

Loading