Remove features from Store properties#333
Merged
Merged
Conversation
giovannivolpe
requested changes
May 24, 2025
Comment on lines
+373
to
+374
| self._random_seed = DeepTrackNode(lambda: random.randint(0, 2147483648)) | ||
| self._random_seed = DeepTrackNode(lambda: random.randint(0, 2147483648)) |
Member
There was a problem hiding this comment.
Why there are two lines of code that seem to do the same?
Can we keep only one?
Collaborator
Author
There was a problem hiding this comment.
Yes! That's an unintentional change.
| Defaults to `False`. | ||
| **kwargs:: dict of str to Any | ||
| Additional keyword arguments passed to the parent `Feature` class. | ||
|
|
||
| """ | ||
|
|
||
| super().__init__(feature=feature, key=key, replace=replace, **kwargs) | ||
| super().__init__(key=key, replace=replace, **kwargs) |
Member
There was a problem hiding this comment.
The removal of feature=feature is the only "functional" change? or are there other changes?
Collaborator
Author
There was a problem hiding this comment.
That is the only one. I see that some more ones got added by accident by my auto-formatter. I'll make sure only this change comes through
BenjaminMidtvedt
force-pushed
the
bm/fix-store-properties
branch
from
50ff0cd to
a24ce66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
featurewas both set as a property of the Store class, as well as a attribute. With this PR, it is only an attribute.This caused feature to be recalculated unecessarily, bypassing the memoization of the Store.
This change causes no changes in output (so no breaking change), but should significantly speed up pipelines using Store.