feat(4.7): Extract MCPToolHandlers into openspace/mcp/tool_handlers.py#36
Merged
Conversation
Extract all 4 MCP tool handlers (execute_task, search_skills, fix_skill, upload_skill) and their 12 helper functions from mcp_server.py into a new openspace/mcp/tool_handlers.py module. Changes: - Create openspace/mcp/ package with __init__.py - Create openspace/mcp/tool_handlers.py (799 lines) with: - 4 tool handlers + register_handlers(mcp) wiring function - All lifecycle helpers (_get_openspace, _get_store, etc.) - Upload metadata helpers (_write/_read_upload_meta) - Cloud import helpers (_cloud_search_and_import, _do_import_cloud_skill) - Result formatting (_format_task_result, _json_ok, _json_error) - Slim mcp_server.py to 220 lines (was 992): bootstrap, FastMCP, server entry - Update test imports: test_auto_import_disabled, test_integration, test_traceback_safety now reference openspace.mcp.tool_handlers - Add 20 new tests in test_mcp_tool_handlers.py All 1,376 tests pass, 117 skipped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 4.7: Extract MCPToolHandlers
Changes
Extraction Summary
Review Results (/8eyes + /collab)
All 1,376 tests pass, 117 skipped.