Epic 5.7: SkillContext + MessageSafety — grounding/ package#45
Merged
Conversation
- Create openspace/agents/grounding/ package - Extract set_skill_context, clear_skill_context, has_skill_context, set_skill_registry into grounding/context.py (68 lines) - Extract cap_message_content, truncate_messages into grounding/messages.py (120 lines) - grounding_agent.py methods become thin delegates - 33 new tests (14 context + 19 messages) - 1,609 passed, 127 skipped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add cap parameter to truncate_messages() so subclass overrides of _MAX_SINGLE_CONTENT_CHARS flow through both call paths - grounding_agent.py delegate forwards self._MAX_SINGLE_CONTENT_CHARS - Add test_custom_cap_forwarded proving cap propagation - Found by Opus 4.6 + GPT-5.4 /collab review (both flagged same issue) - 1,610 passed, 127 skipped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 5.7 — SkillContext + MessageSafety (P5b Start)
What
First extraction of grounding_agent.py (1,181 lines) into
grounding/package:grounding/context.py(68 lines): set_skill_context, clear_skill_context, has_skill_context, set_skill_registrygrounding/messages.py(125 lines): cap_message_content, truncate_messages + _MAX_SINGLE_CONTENT_CHARSKey Fix
Opus 4.6 + GPT-5.4 both caught subclass safety regression:
_truncate_messagespathwasn't forwarding
_MAX_SINGLE_CONTENT_CHARSthrough tocap_message_content.Fixed by adding
capparameter totruncate_messages()and threading through delegate.Review