Epic 5.8: ExecutionLoop + PromptBuilder — grounding/ package#46
Merged
Conversation
- Extract process() (~287 lines) into grounding/execution.py - Extract construct_messages(), _default_system_prompt() into grounding/prompts.py - Helper _build_retrieved_tools_list() extracted from process() body - grounding_agent.py methods become thin delegates - 26 new tests (14 prompts + 12 execution) - 1,636 passed, 127 skipped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 5.8 — ExecutionLoop + PromptBuilder
What
Extract the 3 largest remaining methods from grounding_agent.py:
grounding/execution.py(325 lines):process()core loop +_build_retrieved_tools_listgrounding/prompts.py(82 lines):default_system_prompt,construct_messagesResult
Review