Epic 5.9: ToolCatalog + Visual + Workspace — grounding/ package#47
Merged
Conversation
Extract mid-layer methods from grounding_agent.py into 3 new modules: - grounding/tools.py: _get_available_tools, _load_all_tools - grounding/visual.py: _visual_analysis_callback, _enhance_result_with_visual_context, _select_key_screenshots - grounding/workspace.py: _get_workspace_path, _scan_workspace_files, _check_workspace_artifacts grounding_agent.py delegates to extracted functions via _impl aliases. Pure functions (_select_key_screenshots, _get_workspace_path, _scan_workspace_files) bound as staticmethod. Removes unused BackendType and ScreenshotClient imports from grounding_agent.py. Reduces file from ~796 to 391 lines. 47 new tests across 3 test files. All 107 grounding tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- tools.py: _get_available_tools fallback calls agent._load_all_tools() - visual.py: _visual_analysis_callback calls agent._enhance_result_with_visual_context() - workspace.py: _check_workspace_artifacts calls agent._get_workspace_path/scan - Update test _FakeAgent classes with delegate methods - Found by GPT-5.4 /collab review - 1,683 passed, 127 skipped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 5.9 — ToolCatalog + Visual + Workspace
What
Extract 8 methods from grounding_agent.py into 3 new modules:
grounding/tools.py(99 lines): _get_available_tools, _load_all_toolsgrounding/visual.py(192 lines): visual analysis pipeline (callback, enhance, screenshot selection)grounding/workspace.py(126 lines): workspace file scanning and artifact detectionResult
Review