Epic 5.11: P5b Capstone — grounding/ package integration#49
Merged
Conversation
- Upgrade grounding/__init__.py with full docstring and __all__ exports - Add 32 P5b integration tests: package completeness, no circular imports, backward-compatible import paths, facade delegation, size guards - 1,754 tests passed, 127 skipped, 0 failures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
- Fix circular import tests: pop entire grounding subtree, not just target module - Add 9 async delegation tests proving facade->submodule wiring (process, tools, visual, workspace, results, recording) - Add _make_agent drift guard (auto-detects attrs missing from __init__) - Add identity assertion for backward-compat import paths (is, not just isclass) - Strengthen truncate_messages test with token-exceeding inputs - Add BaseAgent._step/_status to test fixtures - 43 integration tests, 1765 total passed, 0 failures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Strip _-prefixed symbols from grounding/__init__.py __all__ to follow PEP 8 convention. Private helpers remain importable for the facade but are excluded from wildcard imports. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 5.11: P5b Capstone — Facade/Cleanup + Full Review
What
P5b capstone: finalize the
grounding/package extraction that decomposedgrounding_agent.pyfrom 1,181 lines to a 197-line thin facade + 8 focused submodules.Changes
__all__exports for all 8 submodulesbackward-compatible import paths, facade delegation, size regression guards
Metrics
P5b Complete Extraction Map