Skip to content

Conversation

@manuel-sommer
Copy link
Contributor

@dryrunsecurity
Copy link

dryrunsecurity bot commented May 16, 2025

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten
Copy link
Member

valentijnscholten commented May 21, 2025

Thank you. I might be nitpicking, but should we just list all of the urls and use the type to classify them?
For example just show PTR: instead of FQDN? The code seems to assume the PTR record is the FQDN, but it might not be. If the user scanned "google.com" the FQDNin Defect Dojo is shown as ar10s10-in-f238.1e100.net.
This might confuse users. They would need to know the implementation details of the parser to know where the value comes from. It might be easier and more clear if the description for that google.com scan looked like this:

**IP Address:** 172.217.18.238
**PTR:** par10s10-in-f238.1e100.net
**User:** google.com
**custom:** lalala

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per my comment (Adding this to make the review reminder bot happy :-))

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per Vals comment (Adding this to make the review reminder bot happy :-))

@manuel-sommer
Copy link
Contributor Author

Done, sorry, was quite busy

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, happy with all your contributions. approved :-D

@valentijnscholten valentijnscholten added this to the 2.47.2 milestone Jun 9, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch requested a review from hblankenship June 11, 2025 23:51
@mtesauro mtesauro merged commit a33d46d into DefectDojo:bugfix Jun 12, 2025
78 checks passed
@manuel-sommer manuel-sommer deleted the issue_12411 branch June 13, 2025 07:34
xansec pushed a commit to xansec/django-DefectDojo that referenced this pull request Jun 18, 2025
…jo#12466)

* 🐛 Nmap parser: Add url info to description

* fix

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants