-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[fix] gmx-sol - exclude points-farming volume from GMTrade #8085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkzung
wants to merge
9
commits into
DefiLlama:master
Choose a base branch
from
mkzung:fix/gmx-sol-points-farming
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1fc9494
fix(gmx-sol): exclude points-farming volume from GMTrade
mkzung 1f9e780
cap the pagination loop and clarify the no-data error
mkzung c7e7708
catch the farmers that do not hedge, without reaching directional sca…
mkzung 3cb2b7f
name the position map for what it counts
mkzung a876aea
correct the threshold notes against the new rule
mkzung f2ebb21
fix the capital range and the threshold wording
mkzung 9b10a9c
state the idle-capital limit instead of waving it away
mkzung 8be58cc
fail loudly when the day does not fit in one read
mkzung d5d319f
drop the redundant trade count and cut the comment down
mkzung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use
options.startTimestampinstead ofoptions.startOfDayfor time windows.As per coding guidelines, use
options.startTimestamp(orfromTimestamp) for event-based time windows rather thanstartOfDay. If this adapter runs hourly,startOfDaywill incorrectly aggregate all events from midnight up to the end of the current hour, leading to grossly inflated day-to-date cumulative volume being reported for a single hour.🛠 Proposed fix
const fetch = async (options: FetchOptions) => { - const from = new Date(options.startOfDay * 1000).toISOString(); + const from = new Date(options.startTimestamp * 1000).toISOString(); const to = new Date(options.endTimestamp * 1000).toISOString();📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines