add Merkl rewards to existing pools #1827
Open
+99
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastilver
commented
Apr 22, 2025
Comment on lines
+516
to
+595
|
|
||
| const merklNetworks = { | ||
| 1: 'ethereum', | ||
| 137: 'polygon', | ||
| 10: 'optimism', | ||
| 42161: 'arbitrum', | ||
| 1101: 'polygon_zkevm', | ||
| 8453: 'base', | ||
| 60808: 'bob', | ||
| 146: 'sonic', | ||
| 43114: 'avax', | ||
| 80094: 'berachain', | ||
| 56: 'bsc', | ||
| } | ||
|
|
||
| exports.addMerklRewardApy = async ( | ||
| pools, | ||
| protocolId, | ||
| poolAddressGetter, | ||
| ) => { | ||
| try { | ||
| let merklPools = []; | ||
| let pageI = 0; | ||
|
|
||
| while(true) { | ||
| let data; | ||
| try { | ||
| data = await exports.getData(`https://api.merkl.xyz/v4/opportunities?mainProtocolId=${protocolId}&status=LIVE&items=100&page=${pageI}`); | ||
| } catch (err) { | ||
| console.log(`failed to fetch Merkl data for ${protocolId}: ${err}`); | ||
| break; | ||
| } | ||
|
|
||
| if (data.length === 0) { | ||
| break; | ||
| } | ||
|
|
||
| merklPools.push(...data); | ||
| pageI++; | ||
| } | ||
|
|
||
|
|
||
| const merklPoolsMap = Object.fromEntries(Object.keys(merklNetworks).map(id => [merklNetworks[id], {}])); | ||
| merklPools.forEach(pool => { | ||
| if (!merklNetworks[pool.chainId]) { | ||
| return; | ||
| } | ||
|
|
||
| merklPoolsMap[merklNetworks[pool.chainId]][pool.identifier.toLowerCase()] = { | ||
| apyReward: pool.apr, | ||
| rewardTokens: [...new Set(pool.rewardsRecord?.breakdowns.map(x => x.token.address) || [])] | ||
| } | ||
| }); | ||
|
|
||
| return pools.map(pool => { | ||
| const poolAddress = poolAddressGetter ? poolAddressGetter(pool) : pool.pool; | ||
| const merklRewards = merklPoolsMap[pool.chain.toLowerCase()][poolAddress.toLowerCase()]; | ||
|
|
||
| if (!merklRewards) { | ||
| return pool; | ||
| } | ||
|
|
||
| // if the data is already present, don't overwrite it | ||
| if (pool.apyReward || (pool.rewardTokens && pool.rewardTokens.length !== 0)) { | ||
| console.log('pool already has apyReward or rewardTokens', pool.pool); | ||
| return pool; | ||
| } | ||
|
|
||
| return { | ||
| ...pool, | ||
| ...merklRewards, | ||
| } | ||
| }); | ||
| } catch (err) { | ||
| console.log(`Failed to add Merkl reward apy to ${protocolId}: ${err}`); | ||
|
|
||
| // If we fail to fetch Merkl data, just return the original pools | ||
| return pools; | ||
| } | ||
| }; |
There was a problem hiding this comment.
I don't know if this is the right place for this?
I was thinking about moving it into Merkl adapter.
mastilver
commented
Apr 22, 2025
Comment on lines
+517
to
+529
| const merklNetworks = { | ||
| 1: 'ethereum', | ||
| 137: 'polygon', | ||
| 10: 'optimism', | ||
| 42161: 'arbitrum', | ||
| 1101: 'polygon_zkevm', | ||
| 8453: 'base', | ||
| 60808: 'bob', | ||
| 146: 'sonic', | ||
| 43114: 'avax', | ||
| 80094: 'berachain', | ||
| 56: 'bsc', | ||
| } |
There was a problem hiding this comment.
Do you think I should import that from the merkl adapter?
maybe expose it as a separate file?
mastilver
force-pushed
the
additional-merklr-rewards
branch
from
d8df865 to
d289c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.