Document reloadable configs #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nebula-docs-dn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Since the default is meant to be "reloadable" wouldn't it make sense to add pills just for the cases where options are "non-reloadable"? |
jasikpark
reviewed
May 28, 2024
nbrownus
reviewed
May 29, 2024
| @@ -39,22 +39,24 @@ pki: | |||
|
|
|||
| ## pki.cert | |||
|
|
|||
| <Pill className="mb-24">Required</Pill> | |||
| <Pill className="mb-24">Required</Pill> <Pill className="mb-24">Reloadable</Pill> | |||
There was a problem hiding this comment.
We should note that while a certificate is reloadable, it will only be accepted if the ip address hasnt changed. All other properties of the cert can change though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
We didn't have any good listing of which options can be reloaded via a SIGHUP vs those that require a full restart to take effect. This adds a simple badge to indicate which options can be reloaded. AFAICT,
tun.mtuis only reloadable on linux, but that's the only difference between platforms that I could find.