Cleanup debug constants #312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olethomas
reviewed
Oct 29, 2021
| define( 'WP_DEBUG', true ); | ||
| define( 'SCRIPT_DEBUG', true ); | ||
| define( 'WP_DEBUG_LOG', true ); |
There was a problem hiding this comment.
Would this break the debug log implementation in application.php?
[1] https://github.com/DekodeInteraktiv/project-base/blob/main/config/application.php#L93
| define( 'WP_DEBUG_DISPLAY', true ); | ||
| # phpcs:ignore define( 'SCRIPT_DEBUG', true ); |
There was a problem hiding this comment.
Should probably add a small comment to explain how to add SCRIPT_DEBUG and SAVEQUERIES and why they are disabled by default.
|
Closing this in favor of #375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCRIPT_DEBUGandWP_DEBUG_DISPLAYarefalseby default)SCRIPT_DEBUGandSAVEQUERIESby default for local and development. Having these switched on is a big performance impact and not useful in our daily development.More on WP debugging: https://wordpress.org/support/article/debugging-in-wordpress/