Skip to content

Conversation

@isuke01
Copy link
Member

@isuke01 isuke01 commented Nov 7, 2025

The Story is similar as my other PHPCS QOL change.

I see people adds it project to project, I do it too.
The problem is also people tend to name command differently project-to-project.

I think it is good to have it added by default and standarize command.

In this case I used one that I mostly used by Kevin and Jøgen and I stared to use the same notation.

We can agree on any other notation, but I wish to have standarized one.

@isuke01 isuke01 changed the title Add auto fix commands to packades Quality of life change: Auto fix commands for JS, CSS, Format Nov 7, 2025
Copy link
Member Author

@isuke01 isuke01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix duplication

@Clorith
Copy link
Member

Clorith commented Nov 7, 2025

I agree that a unified fix-related command makes sense, this needs a few adjustments before it can be merged;

Currently there is a lint command that will run all commands prefixed with lint:, this means it would also run the fix commands, which I suspect would not be intentional.

Perhaps adding fix: as a prefix instead of a suffix would make more sense? We could then more easily also have a fix:lint shared command to run all fixers, and it does not compete with the existing linting structure.

Also curious how this applies alongside the lint-staged command that's there, they serve different use cases, but the same purpose 🤔

@stian-overasen stian-overasen changed the title Quality of life change: Auto fix commands for JS, CSS, Format Add auto fix commands for JS and CSS lint errors Nov 21, 2025
Copy link
Member

@stian-overasen stian-overasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@stian-overasen stian-overasen merged commit 78327a1 into main Nov 21, 2025
4 checks passed
@stian-overasen stian-overasen deleted the feature/quality-of-life/js-css-fix branch November 21, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants