Skip to content

Conversation

@makindotcc
Copy link

No description provided.

@richarddd
Copy link
Collaborator

@makindotcc thanks for the PR. Can you please adds some tests?

@makindotcc
Copy link
Author

Hello @richarddd. After merge pr is no longer compiling due to this commit:
7988333#diff-30624fb4011d0b71d6e715a9cee4c3d70c8645995ac06423a16af30768ef5b1eL84-L88

I'm not sure how to handle it, since JSRefCountHeader is no longer in quickjs.h, but in quickjs.c. I should also check JS_VALUE_HAS_REF_COUNT before grabbing refcount.
I think correct replacement for my pr would be api to JSClassDef.finalizer, but I can't provide it now, sorry!
Closing pr, because I think this is objectively wrong.

@makindotcc makindotcc closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants