feat: Add lossy conversion between QJS string and Rust string #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"🌍🌎🌏".slice(1)
currently produces a broken surrogate pair. When converting to a rust string, we get UTF8 error.QJS handles this by just printing the invalid utf16 surrogate pair as a replacement char.
This PR introduces a new method
to_string_lossy
that will render a utf8 replacement char for broken surrogate pairs.