Add bounded queue support for enqueue option#1431
Open
GangEunzzang wants to merge 1 commit intoDelgan:masterfrom
Open
Add bounded queue support for enqueue option#1431GangEunzzang wants to merge 1 commit intoDelgan:masterfrom
GangEunzzang wants to merge 1 commit intoDelgan:masterfrom
Conversation
Add support for bounded queues to prevent unbounded memory growth
when using enqueue=True with slow sinks.
New enqueue options:
- enqueue=<int>: bounded queue with specified max size (blocking)
- enqueue={"size": N, "overflow": "block|drop"}: configurable overflow
37d065e to
2e868b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
Add bounded queue support for enqueue option (#1419)
Summary
This PR adds support for bounded queues when using
enqueueto prevent unbounded memory growth with slow sinks.Fixes #1419
Changes
New
enqueueoptions:enqueue=Trueenqueue=100enqueue={"size": 100}enqueue={"size": 100, "overflow": "block"}enqueue={"size": 100, "overflow": "drop"}Overflow policies:
"block"(default): Blocks logging call until queue has space (backpressure)"drop": Silently drops the message when queue is full (non-blocking)Example