Skip to content

add some alohaii songs #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add some alohaii songs #3331

wants to merge 3 commits into from
+33 −0

Conversation

AeraAuling
Copy link
Contributor

About the PR

just adds three songs from the summertide album by alohaii

Why / Balance

music is neat. this music is royalty free and I think they're cute and good.

Technical details

Media

f1648b14c25ed1ab8d93b357d1dc413f

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • add: Added some songs from the Summertide album by alohaii

@AeraAuling AeraAuling requested review from a team as code owners March 28, 2025 05:20
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Audio Changes any audio files size/S 16-63 lines labels Mar 28, 2025
deltanedas
deltanedas requested changes Mar 28, 2025
View reviewed changes
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to get an actual license "royalty free" doesnt mean anything for distribution modification etc

ThataKat
ThataKat approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@ThataKat ThataKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from Direction, just pending license stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas requested changes

@ThataKat ThataKat ThataKat approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes: Audio Changes any audio files Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AeraAuling @deltanedas @ThataKat