Skip to content

Lawboard enhancements #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sowelipililimute
Copy link
Contributor

About the PR

  • lawboards can now be printed at circuit imprinters for 2 diamonds, 10 glass, 2 silver, gold, plasma
  • syndicate lawboards can now be printed at emagged circuit imprinters for 5 diamonds, 5 bananium, 2 silver, 2 gold, 2 plasma, 10 glass
  • lawboards now show their lawset on examine
  • borgs can now have their laws updated with lawboards

Why / Balance

  • sometimes a station doesn't spawn with the lawboards that crew wants, or something happens to make them inaccessible
  • having to destroy a borg chassis every time the laws get disruptive is not fun for anyone involved
  • 10 second visible doafter/popup + required open panel means a borg has to be incapacitated or willing to take the law change

Technical details

  • LawElectronicsInsertionSystem handles updating borg lawsets
  • LawElectronicsExamineSystem handles examining lawboards
  • new lathe recipes and packs for all the lawboards

Media

relawing.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • add: Lawboards now show their laws on examine
  • add: Lawboards, crew and otherwise, are printable at circuit imprinters
  • add: Lawboards can be used to update the lawset of a borg chassis

@sowelipililimute sowelipililimute requested review from a team as code owners April 11, 2025 16:26
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Apr 11, 2025
@Avalon-Proto
Copy link
Contributor

Okay I'm suggesting this right now - the bananium cost is a bad idea,it's hard to even get 1 or 2 let alone 5. This would lock the boards as only being open to a salvage antag, and even then rarely

@foxcurl
Copy link
Contributor

foxcurl commented Apr 11, 2025

Two things:

  1. Aside from them being circuit-adjacent, why put them in the circuit imprinter when theyre a robotics item and it doesnt make as much sense for all scientists + engi to have them?
  2. A confirmation popup for finishing installing the laws would be good, having no feedback after the doafter seems strange.

{
args.PushMarkup(Loc.GetString("law-electronics-examine-law", ("order", law.Order), ("text", Loc.GetString(law.LawString))));
}
args.PushMarkup(Loc.GetString("law-electronics-examine-obeys-to", ("owner", Loc.GetString(lawset.ObeysTo))));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for emag grammar and doesnt need to be shown as every law has it anyway

@deltanedas
Copy link
Member

theyre a robotics item and it doesnt make as much sense for all scientists + engi to have them?

this goes both ways, if only roboticist can make it a borg with funny laws means roboticist KOS

@NoElkaTheGod
Copy link
Contributor

this goes both ways, if only roboticist can make it a borg with funny laws means roboticist KOS

300 IQ gaming: as a roboticist, cut the wires on the doors to robotics before doing funny things. When seccomes knocking, tell them that comebody had broken into robotics and did funny things. Congratulations! You are no longer KOS just because of a borg with funny laws existing.

@ThataKat
Copy link
Contributor

Direction has the following requests, after which it's approved:

  • make all lawboards identically priced (including syndicate ones.)
  • move default board printing to exofab, out of circuit lathe
  • give emagged circuit lathe access to all lawboards
    Thanks!

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Apr 30, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/printable-lawboards branch from c000a97 to a8b5da6 Compare April 30, 2025 16:29
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/printable-lawboards branch from e4d10f3 to c3d312a Compare April 30, 2025 16:31
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants