-
Notifications
You must be signed in to change notification settings - Fork 473
Changing RCD and construction menu sprites to match Delta-V resprites #3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changing RCD and construction menu sprites to match Delta-V resprites #3564
Conversation
…anged construction menu YML to display delta-V sprite instead of upstream one
…ced uranium window
for more information, see https://pre-commit.ci
…ced uranium window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# DeltaV -
not #Delta-V -
for comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also put the sprites in an rsi using copyright field instead of attributions.yml
you can still point to |
The original ones aren't in an RSI either, why change it here? |
because its 2025 |
…b.com/SubspaceEmber/Delta-v into RCD-building-airlocks-windows-sprites
I was able to get the main wheel icons to work with the rsi pretty easily. however, with specifying sprite and state for the sub-menus in the YML they just come back blank every time so far no matter what. I'm wondering if this is a larger limitation, given only two systems in the game that i know of use the pie menu/wheel and both reference direct PNG images. I've been looking through both the emote menu and the RCD menu cs to try and see, but it is admittedly a bit above my head still. Is it possible that the code at present can't specify what state to display? I'm not really sure how i would fix that. Worst case if i can't include the RCD menu in this PR i can drop it and just leave the crafting menu changes? |
if rcd goodcode physically cant use it then just leave it as bare pngs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change comments from #Delta-V
and #Delta V
to # DeltaV
…ed with correct attributions. Formatting fixes.
for more information, see https://pre-commit.ci
Resources/Prototypes/Entities/Structures/Doors/Airlocks/base_assembly.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and make sure to resolve conversations when you're done with them (otherwise merge won't be allowed to go through)
|
||
- files: ["airlocks.png, windows_and_grilles.png"] | ||
license: "CC-BY-SA-3.0" | ||
copyright: "RCD wheel sprites made for DeltaV by https://github.com/SubspaceEmber. Modified from sprites Resources/Textures/Interface/Radial/RCD/airlocks.png and Resources/Textures/Interface/Radial/RCD/windows_and_grilles.png from https://github.com/space-wizards/space-station-14." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link the commit not just repo
@@ -0,0 +1,14 @@ | |||
- files: ["airlock.png, glass_airlock.png"] | |||
license: "CC-BY-SA-3.0" | |||
copyright: "RCD wheel sprites made for DeltaV by https://github.com/SubspaceEmber. based on ported sprites Resources/Textures/_DV/Structures/Doors/Airlocks/Standard/basic.rsi and Resources/Textures/_DV/Structures/Doors/Airlocks/Glass/glass.rsi from https://github.com/tgstation." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permalink not repo link
|
||
- files: ["deconstruct.png, directional.png, directional_reinforced.png, window.png, window_reinforced.png"] | ||
license: "CC-BY-SA-3.0" | ||
copyright: "RCD wheel sprites made for DeltaV by https://github.com/SubspaceEmber. based on ported sprites Resources/Textures/_DV/Structures/Doors/Airlocks/Standard/external.rsi, Resources/Textures/_DV/Structures/Windows/window.rsi, Resources/Textures/_DV/Structures/Windows/directional.rsi, Resources/Textures/_DV/Structures/Windows/reinforced_window.rsi from https://github.com/ParadiseSS13/Paradise/." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to at least the commit
About the PR
Created and added new sprites for airlocks, glass airlocks, windows, reinforced windows, directional windows, and directional reinforced windows for the RCD wheel menu. Updated crafting/construction menu to show the Delta-V sprites instead of upstream, both as construction ghost and in menu.
Why / Balance
Changed to better improve visual consistency across different aspects of the game.
Technical details
Media
Requirements
Breaking changes
None known
Changelog
🆑