Skip to content

Changing RCD and construction menu sprites to match Delta-V resprites #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

SubspaceEmber
Copy link
Contributor

About the PR

Created and added new sprites for airlocks, glass airlocks, windows, reinforced windows, directional windows, and directional reinforced windows for the RCD wheel menu. Updated crafting/construction menu to show the Delta-V sprites instead of upstream, both as construction ghost and in menu.

Why / Balance

Changed to better improve visual consistency across different aspects of the game.

Technical details

  • Edited upstream cs file RCDMenuBoundInterface.cs as this is the only location the main "wheel" sprites for the RCD are referenced and it's directly in a cs file. (Recognize this is an upstream file, would like input on if this can be done in a way that doesn't affect upstream)
  • Created and added new RCD sprites
  • Added attributions YML for new sprites
  • Changed RCD sub-category sprite references
  • Fixed a bunch of file references in structures.yml so show DV sprites in construction menu.

Media

image
image
image
image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None known

Changelog

🆑

  • tweak: Crafting menu now shows Delta-V airlocks and windows instead of upstream.
  • tweak: RCD wheel has new sprites to reflect Delta-V sprites for windows and airlocks.

@SubspaceEmber SubspaceEmber requested review from a team as code owners April 24, 2025 08:15
@github-actions github-actions bot added S: Needs Review size/S 16-63 lines Changes: YML Changes any yml files Changes: C# Changes any cs files labels Apr 24, 2025
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# DeltaV - not #Delta-V - for comments

Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also put the sprites in an rsi using copyright field instead of attributions.yml

@SubspaceEmber
Copy link
Contributor Author

i didn't use an rsi because the sprites for the main wheel are specified in a cs file and are looking for a png, i'm not really sure how exactly i'd get that to work, hence why the sprites are on their own with the attributions.yml as seen in the emotes folder as well. Is it possible to specify rsi state in the cs? This is kinda my first time working with cs and rsi. Apologies if this is a dumb question >.<
image

@deltanedas
Copy link
Member

you can still point to .rsi/state.png for warning or use SpriteSpecifier.Rsi

@Toby222
Copy link
Member

Toby222 commented Apr 25, 2025

also put the sprites in an rsi using copyright field instead of attributions.yml

The original ones aren't in an RSI either, why change it here?

@deltanedas
Copy link
Member

because its 2025

@SubspaceEmber
Copy link
Contributor Author

I was able to get the main wheel icons to work with the rsi pretty easily. however, with specifying sprite and state for the sub-menus in the YML they just come back blank every time so far no matter what. I'm wondering if this is a larger limitation, given only two systems in the game that i know of use the pie menu/wheel and both reference direct PNG images. I've been looking through both the emote menu and the RCD menu cs to try and see, but it is admittedly a bit above my head still. Is it possible that the code at present can't specify what state to display? I'm not really sure how i would fix that. Worst case if i can't include the RCD menu in this PR i can drop it and just leave the crafting menu changes?

@deltanedas
Copy link
Member

if rcd goodcode physically cant use it then just leave it as bare pngs

Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change comments from #Delta-V and #Delta V to # DeltaV

…ed with correct attributions. Formatting fixes.
@github-actions github-actions bot added the size/M 64-255 lines label Apr 26, 2025
@github-actions github-actions bot removed the size/S 16-63 lines label Apr 26, 2025
deltanedas
deltanedas previously approved these changes Apr 28, 2025
@deltanedas deltanedas requested a review from Toby222 April 28, 2025 01:24
Copy link
Member

@Toby222 Toby222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and make sure to resolve conversations when you're done with them (otherwise merge won't be allowed to go through)


- files: ["airlocks.png, windows_and_grilles.png"]
license: "CC-BY-SA-3.0"
copyright: "RCD wheel sprites made for DeltaV by https://github.com/SubspaceEmber. Modified from sprites Resources/Textures/Interface/Radial/RCD/airlocks.png and Resources/Textures/Interface/Radial/RCD/windows_and_grilles.png from https://github.com/space-wizards/space-station-14."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link the commit not just repo

@@ -0,0 +1,14 @@
- files: ["airlock.png, glass_airlock.png"]
license: "CC-BY-SA-3.0"
copyright: "RCD wheel sprites made for DeltaV by https://github.com/SubspaceEmber. based on ported sprites Resources/Textures/_DV/Structures/Doors/Airlocks/Standard/basic.rsi and Resources/Textures/_DV/Structures/Doors/Airlocks/Glass/glass.rsi from https://github.com/tgstation."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permalink not repo link


- files: ["deconstruct.png, directional.png, directional_reinforced.png, window.png, window_reinforced.png"]
license: "CC-BY-SA-3.0"
copyright: "RCD wheel sprites made for DeltaV by https://github.com/SubspaceEmber. based on ported sprites Resources/Textures/_DV/Structures/Doors/Airlocks/Standard/external.rsi, Resources/Textures/_DV/Structures/Windows/window.rsi, Resources/Textures/_DV/Structures/Windows/directional.rsi, Resources/Textures/_DV/Structures/Windows/reinforced_window.rsi from https://github.com/ParadiseSS13/Paradise/."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to at least the commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants