Skip to content

Port Goobstation's autoinjectors #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

BarryNorfolk
Copy link
Contributor

@BarryNorfolk BarryNorfolk commented Apr 26, 2025

About the PR

Ports auto-injectors from goob station, this is ONLY the autoinjectors and nothing else.

Original PRs:
Goob-Station/Goob-Station#953
Goob-Station/Goob-Station#1021
Goob-Station/Goob-Station#1085
Goob-Station/Goob-Station#1798
Goob-Station/Goob-Station#2298

Why / Balance

Paramedics and Security corpsman should be able to rapidly respond to certain events that require direct and FAST help for their peers. Standing still for a syringe while getting shot is just not applicable, and we should be able to have people fall back and get SOME help at least.

Technical details

I only wanted the hypospray/autoinjector code + YAML + sprites, so I've had to do a more narrow cherry pick and pull out anything related to the goob specific security setup. This means they are all "new" commits by me, which sucks, but hopefully we have enough of a record here + in code for who did what and where.

I've also had to remove a bunch of cartridges for chemicals that we don't have, so I did that together in one big go rather than add a bunch of shit and then the next commit remove it.

I've included the current-ish license info that they have in the top of the file, not sure if I should keep it there since the original PRs didn't have it. I can remove them if needs be.

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog
🆑 Aviu00, Goobstation et al, BarryNorfolk

  • add: Added Autoinjectors for medical and security capable of injecting specific cartridges. Printable at your local Med/Sec techfabs.

@BarryNorfolk BarryNorfolk requested review from a team as code owners April 26, 2025 15:21
@github-actions github-actions bot added size/L 256-1023 lines S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi and removed S: Needs Review labels Apr 26, 2025
Copy link
Contributor

github-actions bot commented Apr 26, 2025

RSI Diff Bot; head commit f9f9d45 merging into dae321c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Goobstation/Objects/Specific/Medical/autoinjector.rsi

State Old New Status
cartridge1 Added
inhand-left Added
inhand-right Added
medical-base Added
security-base Added

Resources/Textures/_Goobstation/Objects/Specific/Medical/cartridge.rsi

State Old New Status
base Added
filling Added

Edit: diff updated after f9f9d45

@BarryNorfolk BarryNorfolk force-pushed the port/goobstation_autoinjectors branch from 4a6684d to f76bb39 Compare April 26, 2025 16:06
@gusxyz
Copy link
Contributor

gusxyz commented Apr 26, 2025

Why not just use goobmod?

@BarryNorfolk
Copy link
Contributor Author

I have no idea what that is

@Radezolid
Copy link
Contributor

Test fail is real.

@deltanedas
Copy link
Member

Why not just use goobmod?

because effort

@misandrie
Copy link
Contributor

Why not just use goobmod?

because effort

"holier than thou" codebase.... refusing to commit some effort...

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Apr 27, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@BarryNorfolk BarryNorfolk force-pushed the port/goobstation_autoinjectors branch from f76bb39 to a637df8 Compare April 27, 2025 08:51
@BarryNorfolk BarryNorfolk force-pushed the port/goobstation_autoinjectors branch from a637df8 to e5dece4 Compare April 27, 2025 10:28
@github-actions github-actions bot added Changes: Localization Changes any ftl files and removed S: Merge Conflict Fix your PR! labels Apr 27, 2025
@BarryNorfolk BarryNorfolk requested a review from deltanedas April 27, 2025 10:35
@BarryNorfolk BarryNorfolk force-pushed the port/goobstation_autoinjectors branch from e5dece4 to 4dc8419 Compare April 27, 2025 16:46
@BarryNorfolk BarryNorfolk force-pushed the port/goobstation_autoinjectors branch from 4dc8419 to f9f9d45 Compare April 27, 2025 18:34
@ShepardToTheStars
Copy link
Contributor

A few things bother me. (Im not part of direction, just someone who mains medical on DV, so take this with a grain of salt.)

  1. Its available without research. You can print these right away from the medfab.
  2. Printing the cartridges requires zero interaction from chem. You basically print free chems from the medfab for a few steel and glass.
    image
  3. The concept of pre-made cartridges feels pretty braindead from a medical standpont. There's not really any nuance. For instance, you're the corpsman in combat with this (assuming no lasers), you would basically just be spamming the brute cart in everyone who's taken damage, and maybe the adrenaline in those who haven't taken much damage. I'd personally rather see something like frontier's low-capacity hypo with a cooldown over something that involves cartridges.

@Axianamos
Copy link

Axianamos commented Apr 28, 2025

I kinda agree. If single use cartridges started empty but could be filled, they'd be a great tool for parameds and corpsmen, but free chems from a medfab make no sense.

This is very very WYCI but empty cartridges could be loaded at a chem master, made similar to pills, to prevent antags from just making free death hypo's without a bit of effort.

@deltanedas
Copy link
Member

a chemmaster is much easier to get than some death chems, and filling a 10u cartridge with the 20 genetic chem to instantly RR someone isnt good

@Avalon-Proto
Copy link
Contributor

a chemmaster is much easier to get than some death chems, and filling a 10u cartridge with the 20 genetic chem to instantly RR someone isnt good

To be FAIR dorux works on corpses now so that's not RR, just annoying to fix

@Axianamos
Copy link

Maybe just restrict what chems are allowed in each injector. Starlight does something similar with it's weird medkit thingies (I was on starlight once and got eaten by a dragon 10 minutes later so I didnt get a chance to play with them much). They require specifically Bic to work, then just function as rapid bandages

@BarryNorfolk
Copy link
Contributor Author

I had originally made this version here #2701 but it fell off. It had some of what you're talking about but I never got to the point of getting sprites.
I don't mind rebasing that and bringing it back up if that's what Direction would rather have.

I have no strong opinions on this...

@gusxyz
Copy link
Contributor

gusxyz commented Apr 28, 2025

Why not just use goobmod?

because effort

arguably less effort. you can just drag and drop it into the solution and build it ..
check our entrypoint code DELTA ITS WORTH IT BRO.
STOP BEING LAZY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants