Skip to content

Easy upgradeable solar panels #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

Radezolid
Copy link
Contributor

@Radezolid Radezolid commented Apr 26, 2025

About the PR

This PR allows the player to upgrade the solar panels with the material glass directly. It also allows you to go back to previous states.

Why / Balance

I always felt it was weird that you weren't able to upgrade solars this way like you could with windows.

Technical details

N/A

Media

2025-04-28.20-06-53.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A

Changelog

🆑

  • add: Solar panels now can be upgraded by using the upgrade material glass directly on it. You can also go back to a previous state by applying a different glass on it.

@Radezolid Radezolid requested a review from a team as a code owner April 26, 2025 23:00
@github-actions github-actions bot added Changes: YML Changes any yml files size/S 16-63 lines S: Needs Review labels Apr 26, 2025
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5 is too short do like 1.5

@Radezolid Radezolid requested a review from deltanedas April 27, 2025 09:42
@dvir001
Copy link
Contributor

dvir001 commented Apr 27, 2025

Can you also support swapping to lower tiers (any to any)

@Radezolid
Copy link
Contributor Author

Can you also support swapping to lower tiers (any to any)

Sure, will do once I get back home. It might need some changes if it's meant to go back to glass, like it would require uranium glass instead of uranium. My logic here was reusing the panel's glass.

@github-actions github-actions bot added size/M 64-255 lines and removed size/S 16-63 lines labels Apr 28, 2025
@Radezolid
Copy link
Contributor Author

Radezolid commented Apr 28, 2025

Can you also support swapping to lower tiers (any to any)

I completely forgot. It now supports going back to previous tiers, but it needs to be in glass form.
Also changed the PR media.

@deltanedas deltanedas enabled auto-merge (squash) April 28, 2025 23:13
@deltanedas deltanedas merged commit 38362fd into DeltaV-Station:master Apr 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants