-
Notifications
You must be signed in to change notification settings - Fork 594
admin logs for research, glimmer, artifacts #4994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
admin logs for research, glimmer, artifacts #4994
Conversation
| _adminLogger.Add( | ||
| LogType.ArtifactNode, | ||
| LogImpact.Low, | ||
| // note: effect type is already logged by ToPrettyString(node) | ||
| $"{ToPrettyString(ent.Owner)} spawned with node {ToPrettyString(node)} with depth {node.Comp.Depth}; effect status {effectStatusString}; {triggerStr.ToString()}" | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems like it would get really noisy. It would spit out an admin log for each node when an artifact spawns, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. There are 10-16 nodes in each artifact. It'll shoot off 10-16 logs back to back whenever an artifact spawns.
I guess I'm not totally sure how many artifacts get generated in a round. I imagined 6 would be an average number, but maybe it's more like 10 with how many salvage wrecks there are? Surely not more than 20 or 30? (30 artifacts would be only 400 logs per round)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y'know let me move these to their own log_type. Then, worst case scenario if they do blow up more than we want they'll be really easy to clear out from the database. (step 1: revert this PR, step 2: DELETE FROM admin_log WHERE log_type=425 or whatever)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a lot more may get generated, though not necessarily utilized. There are multiple that spawn on red rock at round start and possibly on salv wrecks as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would never expect more than 100 artifacts in a round, would we? Even 100 artifacts would only be 1600 logs per round, which pales in comparison to the main logs in this PR. (passive glimmer generation and passive research generation are ~8000 per round each)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add some intelligent filtering on "only log the artifacts that are actually used", but I think that might be premature.
My goal with this particular "what triggers does a node have" log is so we can reconstruct the full trees. Seeing what nodes researchers didn't unlock can be just as useful as seeing which ones they did -- I'd like to try to analyze the actual/perceived difficulty of trigger types by using these logs.
About the PR
Added new epistemics admin logs. I intend to use them to analyze generally how players are generating research points, and how players are interacting with glimmer, anomalies, and xenoarch.
We should start collecting data ASAP. Grafana visualizations or one-off analyses based on these logs will come later.
To be clear: these are logs that appear in the `adminlogs` menu, or the
admin_logdatabase table. They are "LogSeverity.Low", so they do not spam/appear in the chat window. Most admins won't know they're thereWhy / Balance
Xenoarch is busted. The recent glimmer scaling PR has combined poorly with other scalings, and discord users are reporting that xenoarcheologists are finishing the research tree very early in the shift, due to nodes producing insane amounts of research points.
It'd be awesome if we start collecting data now, so that we will have solid before & after statistics on whatever balance changes we make in the near future.
Technical details
There are 11 new types of log messages being generated. In total, I estimate ~20,000 more logs per round to be generated. The current average (as discussed on discord) is probably about ~150,000 per round, so this is a fairly significant increase!
However, I think these are okay to add for now, and we can look at slimming down our logs over the next couple months. A month or two of 15% more logs shouldn't break the bank on server disk storage. (we're currently storing the past year of rounds)
Examples of the 11 new logs:
New
ResearchcategoryNew
ArtifactDetailscategory(originally had these in the existing
ArtifactNodebut I'd like to keep them separate in case we want to revert this PR & purge these logs)New
Glimmercategory(a lot of things change glimmer. I just picked out some of the most "important" ones; we can group the rest into an "Other" category on Grafana, for now.)
Media
Requirements
Breaking changes
Changelog