-
Notifications
You must be signed in to change notification settings - Fork 593
Reinforced cameras / ai cameras and router #5027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
RSI Diff Bot; head commit 379d46e merging into 5eaf79d Resources/Textures/_DV/Structures/Wallmounts/Reinforced_camera.rsi
|
Signed-off-by: snowywinters <[email protected]>
for more information, see https://pre-commit.ci
ShepardToTheStars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend creating a SurveillanceCameraReinforcedBase and putting all of the common attributes on that. It would greatly reduce the amount of duplicated code. Then you could double-parent based off the department. I added it to the first suggestion of the reinforced camera file.
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCamera | ||
| name: device-frequency-prototype-name-surveillance-camera | ||
| frequency: 1926 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraEngineering | ||
| name: device-frequency-prototype-name-surveillance-camera-engineering | ||
| frequency: 1931 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraSecurity | ||
| name: device-frequency-prototype-name-surveillance-camera-security | ||
| frequency: 1932 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraScience | ||
| name: device-frequency-prototype-name-surveillance-camera-science | ||
| frequency: 1933 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraSupply | ||
| name: device-frequency-prototype-name-surveillance-camera-supply | ||
| frequency: 1934 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraCommand | ||
| name: device-frequency-prototype-name-surveillance-camera-command | ||
| frequency: 1935 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraService | ||
| name: device-frequency-prototype-name-surveillance-camera-service | ||
| frequency: 1936 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraMedical | ||
| name: device-frequency-prototype-name-surveillance-camera-medical | ||
| frequency: 1937 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraGeneral | ||
| name: device-frequency-prototype-name-surveillance-camera-general | ||
| frequency: 1938 | ||
|
|
||
| - type: deviceFrequency | ||
| id: ReinforcedSurveillanceCameraEntertainment | ||
| name: device-frequency-prototype-name-surveillance-camera-entertainment | ||
| frequency: 1939 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these needed? Can't we just use the previous frequencies as as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are the default camera frequencies for the camera subnet they where just added since each mapping camera has to have its own variant so mappers can map then in different departments faster like the normal cameras but they do use the base camera frequency since that frequency is that cameras subnet
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Show resolved
Hide resolved
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Show resolved
Hide resolved
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Show resolved
Hide resolved
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Show resolved
Hide resolved
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Show resolved
Hide resolved
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Show resolved
Hide resolved
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Show resolved
Hide resolved
...ypes/_DV/Entities/Structures/Wallmounts/WallmountMachines/reinforced_surveillance_camera.yml
Outdated
Show resolved
Hide resolved
Recommend by ShepardToTheStars thanks a lot for the recommendation and code start
for more information, see https://pre-commit.ci
|
approved |
|
@ShepardToTheStars will this be looked at to merge Or was it sadly forgotten with the massive amounts of work flow? |





About the PR
Adds reinforced cameras and a new sebnet for Ai cameras/routers
Why / Balance
https://discord.com/channels/968983104247185448/1447879561122418731
main reason was because meteors could take out the cameras from over 5 tiles away and the normal camera was too easy to take out by random stuff
For the ai camera subnet is is so the Ai core cameras don't take up space in commands subnet and being its own area it should have its own
Technical details
the reinforced cameras have the following
2.explosion resistance 75%
NOTE: for meteors and any c4 or bombs like it can take out the cameras 1 tile away and can only survive one non direct impact from a meteor and a direct impact will take it out
i don't believe i forgot anything
AI camera subnet
Media
Requirements
Breaking changes
Changelog
🆑