Ninja Stealth Fix?/Nerf?

[ShepardToTheStars]

About the PR

Doing at least 5 damage to the ninja will reveal the ninja.

Why / Balance

The AttackedEvent only applies to melee attack events, not to projectiles or general damage.

Technical details

Using the much more generic DamageChangedEvent instead of AttackedEvent. I tried using ProjectileHit and other ranged attacking events but they just weren't working so I'm guessing they were marked handled or whatever.

But this does a few checks.

• Is there a damage change? If no, return.

• Is the change in damage healing only? If yes, return.

• Does the damage have a source still? If no, it might be passive healing, airloss from space, bleed damage, etc, so let's check for those things.

  • Was there damage and healing? If so, return because its probably just an OD from 10u derma or whatever.
  • If the damage didn't have brute or burn types, then return.

• Does it meet the minumum damage requirement? (4 damage)? If no, return

• Then reveal the ninja (but only if its stealthed)

Media

simplescreenrecorder-2026-01-14_13.09.43.mp4

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an in-game showcase.

Licensing

• I confirm that I am the creator of the content in this PR, and allow licensing it under the following license(s), or that the original author has given me permission to do so:
  • AGPL (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://choosealicense.com/licenses/mit/)

Changelog

🆑

• tweak: The ninja is now revealed with hit with attacks, projectiles, explosions, and grenades that do damage.
• fix: The ninja is now revealed with hit with attacks, projectiles, explosions, and grenades that do damage.