Skip to content

Conversation

@DisposableCrewmember42
Copy link
Contributor

@DisposableCrewmember42 DisposableCrewmember42 commented Jan 15, 2026

Note

This is nowhere near ready, only making this draft PR to collect feedback on balancing and document I'm working on it so nobody ends up doing duplicate work.

About the PR

The RevenantStasis system is using the old status effects system. I want to migrate it to the new one and fix inconsistencies in the implementation as well as address balancing concerns brought up in #5125.

The plan is:

  • Make salting the rev ectoplasm actually possible. Adding salt to the ectoplasm solution will add 50% of the regular respawn delay to the status effect duration. The time adjustment can only be applied once to each instance of Ecto.
  • Replace the failed grinding explosion with something else; it ends up destroying the grinder and the ecto with it, which is clearly not the intended behavior.
    • I'm thinking of releasing a cloud of cold miasma and displaying a pop-up text on the grinder.
  • Salting should be actually required for the Revenant to be successfully ground.
    • This wasn't properly implemented before, the code mentions various ways it was presumably planned to be implemented. There are unused variables and used variables named in misleading ways.
    • Currently, it requires that an item tagged with Salt or Holy to be ground together with the Ecto. There is no proto tagged with either, so it always explodes.

Why / Balance

Technical details

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files size/M 64-255 lines labels Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# Changes any cs files Changes: YML Changes any yml files size/M 64-255 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant