[not quite new antag]conspirators v2

[stormyatt]

About the PR

made conspirators a subgamemode
added a leader vote system
added a objective vote system
added a kit(gives materials and other maintence diving stuff)
added a new set of objectives that replaces the original
made conspirators objective issuer criminal because i like consistency
(check out the design doc for more exacts)

Why / Balance

I like the idea of a group antag and a antag based around doing gimmicks. so i made conspirators a subgamemode since that was the main complaint, gave a kit for the other, and votes to make it easier to organize and get the gimmick the players want to do.

Technical details

changed the conspirators systems to add two vote systems by copying the cosmic cult one and making needed changes. changed the client so the conspirator leader icon showed up. the rest is yaml to gamerules and a new theiving kit esque item. almost entirely within _harmony and _DV

Media

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an in-game showcase.

Licensing

• I confirm that I am the creator of the code in this PR, and allow licensing it under the following license(s), or that the original author(s) has given me permission to do so:
  • AGPL (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-MIT.txt)

Changelog

🆑

• add: conspirators as a subgamemode
• add: conspirators package, a thieving satchel like item for conspirators
• add: conspirators leader vote, a system to elect a leader for the conspiracy
• tweak: replaced conspirators objectives with a new set of 9. these nine are voted for which one instead of by random chance.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

RSI Diff Bot; head commit 34a6abe merging into c916f9a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Objects/Misc/conspirators_package.rsi

State	Old	New	Status
icon			Added

Resources/Textures/_Harmony/Interface/Misc/job_icons.rsi

State	Old	New	Status
ConspiratorLead			Added

Edit: diff updated after 34a6abe

[ALICEHUNTERS]

nitpicked issue ermmm... unmergeable until fix sory

[stormyatt]

nitpicked issue ermmm... unmergeable until fix sory
dont know what is mispleat help :c

[stormyatt]

ok the debug keeps aborting the check before finishing, assit?

[stormyatt]

Someone please help I don’t know what is failing here

[Stxcking]

Hey @stormyatt, our CR bot is currently down to pull this in but is this ready for discussion? Feel free to ping me if it is and I can see about pulling it in for CR to review.

[Stxcking]

A public CR discussion will be held and should last at least 3 days and up to 7 days as it is enabling a game mode that the server has tested in the past with major tweaks. Thank you!

[Stxcking]

There was not much discussion but considering this was test merged once before and this version is modifications and tweaks that reflected the feedback from the test merge, I don't think an extension is needed at this time. This will be approved when the objective "Enforce the law security can not" is removed from the objective vote/list as we foresee issues with it encouraging players to validhunting. Thank you!