Normal Drinker Vulp Trait and Speedup Drinking as MessyDrinker

[Coryler]

About the PR

Made Messy Drinker faster drinker and added a Trait which makes Vulps normal drinker again

Why / Balance

Makes Messy Drinker a bit more senseful as why you're messy. Also allows people who don't want to be that... to be don't.

Technical details

• C# changes, addition by adding references to Messydrinker
• ftl changes for traits name desc
• yml for trait

Media

Screencast_20260820_102808.webm

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an in-game showcase.

Licensing

• I confirm that I am the creator of the code in this PR, and allow licensing it under the following license(s), or that the original author(s) has given me permission to do so:
  • AGPL (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-MIT.txt)

Changelog

🆑

• add: Normal Drinker Traits for Vulps
• tweak: Messy Drinker speed for drinking drinks

[delta-v-bot]

Triaged by siphynith:
This PR requires a content review discussion, which will be held in public.

microbalancing pr world championship

You can view the discussion here and write comments starting with !discord to send messages into the thread.
The review duration has been set to 1 days.

[delta-v-bot]

CR consensus: Approved

it’s not that deep

Review closed by siphynith.

[SirWarock]

As detailed in the Content-Review channel, the trait "Normal drinker" is subject to removal once the vulpkanine jump ability has been added.

This comment serves as a warning, and will be used in case complaints such as "But I've grown accustomed to the trait!" or "the trait is an inherent part of my character!" are made.

[ShepardToTheStars]

Reduction implies that you're subtracting from the time, not using as a multiplier. Probably can be a float too.

Suggested change

	public FixedPoint2 DrinkDelayReduction = 0.5;
	public float DrinkSpeedMultiplier = 0.5f;

[ShepardToTheStars]

Suggested change

	trait-normal-drinker-desc = You're not like your kin. You drink sophisticated.
	trait-normal-drinker-desc = You're not like your kin. You drink more sophisticated, but you do not drink nearly as fast as other vulpkanins.

[ShepardToTheStars]

• I'm not a huge fan of putting this in IngestionSystem.Blockers.cs.
• This doesn't check if the person drinking is the person who has MessyDrinker (aka it doesn't check are you drinking yourself or is someone feeding you).
• Not a fan of hard-coding MessyDrinkerSolution

It may be better to put this in IngestionSystem.cs, right before the DoAfter and right after CanConsume, like so:

        // Check if despite being able to digest the item something is blocking us from eating.
        if (!CanConsume(args.User, entity, args.Ingested, out var solution, out var time))
            return;

        // BEGIN DeltaV - Messy Drinkers drink faster
        if (args.User == entity.Owner && TryComp<MessyDrinkerComponent>(entity, out var messyDrinker))
        {
            var proto = GetEdibleType(food);
            if (proto is { } edibleType && messyDrinker.SpillableTypes.Contains(edibleType))
                time *= messyDrinker.DrinkSpeedMultiplier;
        }
        // END DeltaV

        if (!_doAfter.TryStartDoAfter(GetEdibleDoAfterArgs(args.User, entity, food, time ?? TimeSpan.Zero)))
            return;