Handheld radio microphone toggle. +prediction - #6454
Open
och-och wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
S: Needs Review
Contributor
|
RSI Diff Bot; head commit 2ce2548 merging into 66b95a4 Resources/Textures/_DV/Objects/Devices/securityhandy.rsi
Resources/Textures/_DV/Objects/Devices/communication.rsi
|
for more information, see https://pre-commit.ci
delta-v-bot
Bot
added
the
No Content Review Needed
|
Triaged by siphynith: This PR does not require a content review discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Added the ability to toggle microphone and speaker separately on handheld radios, which can be done via primary interaction for microphone and secondary interaction for speaker, or via right-click verbs (intercoms get this too btw). Status is shown on the sprite itself and in examine text.
And
RadioDeviceSystemis now predicted.Why / Balance
It's nice to be able to listen on handheld without having to spam it with surrounding chaos.
Technical details
RadioMicrophoneComponentandRadioSpeakerComponentnow extendDVRadioToggleable. I don't know if that's the right way to do that.RadioDeviceSystemis now predicted - most of it is moved from server to shared via changes in the original shared class and a new part of it in _DV. Modern upstream now has this predicted too, so potentially problematic in the future.RADIOFREQUENCYlocalization function for ftl files (!important: this has recently been addressed upstream in a different way. Previously and in this PR frequency was an integer but displayed as a float; in upstream it's just a fixed point fraction now).RadioMicrophoneComponentandRadioSpeakerComponent. Intercom now uses those directly.Media
Examine shows what's on and off and channels (speaker and microphone components are able to have different channels and speaker's channel list is a list so it could listen to multiple channels (this was always possible, this pr does not add an in-game feature to change channels)):
All the different states:
They glow in the dark:
And are visible in hands (with the state still represented) (sec radio didn't have these at all; yellow and red ones are tweaked a little too and show in the farther hand when facing east/west):
Requirements
Licensing
Changelog
🆑 och