Fix/Lower Asakim Weight - #6455
Open
kotobdev wants to merge 2 commits into
Open
Conversation
|
Triaged by javadocs: This PR does not require a content review discussion. |
| # startAudio: | ||
| # path: /Audio/Misc/notice1.ogg | ||
| weight: 3 | ||
| weight: 0.5 # DeltaV - was 2, got moved to more active scheduler, now 0.5 |
Contributor
There was a problem hiding this comment.
Are you sure you want it to be that low?
Contributor
Author
There was a problem hiding this comment.
Doing a bit more digging- seeing as Asakim are now present in both BasicAntagEventsTableDeltaV and UnknownShuttlesTableDeltaV instead of just the latter, the highly-reduced weight is probably warranted. Assuming I'm reading everything correctly.
Contributor
There was a problem hiding this comment.
Ah, would you rather just remove them from BasicAntagEventsTableDeltaV?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Asakim are allegedly rolling multiple times per day now post-#6401, and have the same weight as a loneop- or half the weight of the ever-ubiquitous DisasterVictims. This is extraordinarily not what they are supposed to be. Weight has been lowered to one-sixth of current, 3 to 0.5.
Why / Balance
I mean technically I only needed to lower it to 1, as it's always sat generally around "half the weight of SRN", but Asakim are supposed to be the rarest antag in the game and this new scheduler seems to throw way more shuttle antags overall. so shrug
Really, they probably shouldn't be in this table at all, but do you know how long it takes to get a deltav devenv open with rider? ESPECIALLY after contributing to another fork? Takes like 15 minutes! 32gb of DDR4 ram with the repo stored on a HDD is actual torture. Oh, and I always have to swap github accounts and git information whenever I change repos, which is just a nightmare. This doesn't have anything to do with the PR I'm just tired and don't feel like doing anything more then a number change
Technical details
if you request changes i will cry just do it through github so i can do the automated signoff ibeg
Media
no
Requirements
Licensing
Changelog
🆑