Waq/feature/delwaq 1250 investigate fractional step#777
Open
arjenmarkusdeltaresnl wants to merge 4 commits intomainfrom
Open
Waq/feature/delwaq 1250 investigate fractional step#777arjenmarkusdeltaresnl wants to merge 4 commits intomainfrom
arjenmarkusdeltaresnl wants to merge 4 commits intomainfrom
Conversation
The new integration option looks promising, but I need to get a few things correct still - notably the mass balances and the arbitrary-looking scale factor.
I am not satisfied with the fact that the process terms are all zero in the monitoring file. That needs to be corrected, but this change is not the fix I thought it was.
It turns out that the mass balance information was partly destroyed by introdcuing the inbetween step in the integration scheme. Now explicitly restoring the overall contribution of processes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link