UNST-9720 Made operand an integer enum#780
Open
KoenBussemakerDeltares wants to merge 10 commits intomainfrom
Open
UNST-9720 Made operand an integer enum#780KoenBussemakerDeltares wants to merge 10 commits intomainfrom
KoenBussemakerDeltares wants to merge 10 commits intomainfrom
Conversation
KoenBussemakerDeltares
force-pushed
the
all/task/UNST-9720_improve_operands
branch
3 times, most recently
from
10d5d35 to
b0cd404
Compare
KoenBussemakerDeltares
force-pushed
the
all/task/UNST-9720_improve_operands
branch
from
9bac99f to
34f09e2
Compare
FlorisBuwaldaDeltares
approved these changes
Apr 16, 2026
Contributor
FlorisBuwaldaDeltares
left a comment
FlorisBuwaldaDeltares
left a comment
There was a problem hiding this comment.
I think this is an improvement, if this breaks stuff it's worth fixing, the only thing I don't like is those use with rename module uses, I feel like we should maybe rename the ec module operand to prevent accidental conflicts in the future?
FlorisBuwaldaDeltares
approved these changes
Apr 20, 2026
Contributor
FlorisBuwaldaDeltares
left a comment
FlorisBuwaldaDeltares
left a comment
There was a problem hiding this comment.
looks great! :)
KoenBussemakerDeltares
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Changed the type of operand from a character to an "enum" (just an integer in fortran). This is in preparation for functional changes which will get a separate PR.
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link
https://issuetracker.deltares.nl/browse/UNST-9720