All/feature/delwaq 1236 combine dynamo processes#793
Open
ye4deltares wants to merge 14 commits intomainfrom
Open
All/feature/delwaq 1236 combine dynamo processes#793ye4deltares wants to merge 14 commits intomainfrom
ye4deltares wants to merge 14 commits intomainfrom
Conversation
First 5 fortran subroutines.
Not yet finished.
michelle-deltares
requested changes
Apr 14, 2026
Contributor
michelle-deltares
left a comment
michelle-deltares
left a comment
There was a problem hiding this comment.
- Nice work! Good first steps, but I think it needs more work.
- I saw some typos in the in names of the Fortran routines in the csv-files. Does it actually run at the moment?
- You need to update from main, because I saw several changes in the processes in main that are not in this branch (e.g. BLOOM timestep, sedimentation). That is a bit confusing, and that needs to be merged anyways.
- For the code, for now I just made some layout remarks. I will have a closer look in a second review.
…tps://github.com/Deltares/Delft3D into all/feature/DELWAQ-1236-combine-DYNAMO-processes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A list of processes in Dynamo have been integrated to less processes.
Two new integrated processes have been integrated.
Two new fortran code were added: dynamo.f90 and dynpro.f90.
Evidence of the work done
Tests
In the end, all the testbank tests are green.
Documentation
Also need updated (in a seperate issue).
Issue link