DELWAQ-1242 Retrieving Latitude from D-Flow FM when using online DELWAQ#805
Conversation
michelle-deltares
added
enhancement
| real(hp), allocatable, dimension(:, :) :: waqoutputs !< waq outputs, dim(noout,Ndkx) | ||
|
|
||
| integer :: isfsurf !< pointer to surface segment function | ||
| integer :: isflat !< pointer to latitude segment function |
There was a problem hiding this comment.
I suggest using the name "isflatitude" - now I read the name as "is flat", whereas it is not zero, if the model is NOT flat.
There was a problem hiding this comment.
Are you telling me that earth isn't flat ;-).
I was in doubt, and I did notice it had become 'flat', but didn't notice the consequence of the combination with 'is'. :-D. I'll update this.
| else | ||
| num_spatial_time_fuctions = num_spatial_time_fuctions + 1 | ||
| isflat = num_spatial_time_fuctions | ||
| call realloc(sfunname, num_spatial_time_fuctions, keepExisting=.true., fill='latitude') |
There was a problem hiding this comment.
Why not reuse the paramter clatitude?
There was a problem hiding this comment.
Oh, that is a nice suggestion. That could be don on other locations as well, but I think not always... I think I had some issues with string comparison, which I resolved by using a parameter.
I think this has to do with the function call... Since I don't want to use the parameter only for this one, and also do not want to change it everywhere else, I leave it like it is. I'll focus on the weird fact that two unrelated testcases are now failing. Restart runs, while the 'normal' version have no issue....
2 participants
What was done
Evidence of the work done
Tests
Documentation
Issue link
https://issuetracker.deltares.nl/browse/DELWAQ-1242