Skip to content

UNST-9814: Rename SecchiDepth2 and SecchiDepth2Fraction keywords, add documentation#809

Open
thomas-pijls wants to merge 6 commits intomainfrom
all/task/UNST-9814_rename_secchidepth2
Open

UNST-9814: Rename SecchiDepth2 and SecchiDepth2Fraction keywords, add documentation#809
thomas-pijls wants to merge 6 commits intomainfrom
all/task/UNST-9814_rename_secchidepth2

Conversation

@thomas-pijls
Copy link
Copy Markdown
Contributor

@thomas-pijls thomas-pijls commented Apr 15, 2026 •
edited
Loading

What was done

Did some renaming:

  • Keyword SecchiDepth2 to SecchiDepthNonPenetrative
  • Keyword SecchiDepth2Fraction to SecchiDepthNonPenetrativeFraction
  • Variable DIFFUSE_ATTENUATION_COEFFICIENT_FACTOR to POOL_ATKINS_PARAMETER

Set the old SecchiDepth2 and SecchiDepth2Fraction keywords to deprecated.

Evidence of the work done

  • Video/figures
    <add video/figures if applicable>
  • Clear from the issue description
  • Not applicable

Tests

  • Tests updated
    <add testcase numbers if applicable, Issue number>
  • Not applicable

Documentation

  • Documentation updated (added documenation to User Manual and file-specifications repo)
  • Not applicable

Issue link

KoenBussemakerDeltares
KoenBussemakerDeltares reviewed Apr 20, 2026
View reviewed changes
Comment thread src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_data/m_physcoef.f90 Outdated
Comment thread src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_data/unstruc_model.f90
@thomas-pijls thomas-pijls enabled auto-merge (squash) April 20, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoenBussemakerDeltares KoenBussemakerDeltares KoenBussemakerDeltares approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomas-pijls @KoenBussemakerDeltares