Skip to content

Drop Svn support#10

Merged
hrajagers merged 3 commits intomainfrom
task/drop_svn_support
Mar 25, 2026
Merged

Drop Svn support#10
hrajagers merged 3 commits intomainfrom
task/drop_svn_support

Conversation

@hrajagers
Copy link
Copy Markdown
Member

@hrajagers hrajagers commented Mar 24, 2026

Remove support for Subversion revisions since we've been using Git now for three years.
Keep the $HeadURL$ and $Id$ keywords since they are processed by process_keywords when building the Delft3D-MATLAB interface distribution.

What was done

  • Remove SVN-based revision detection and internal svnversion implementation from determine_revision.
  • Replace the old svnstripfile behavior with process_keywords that replaces keyword tokens using provided values.
  • Update the Delft3D-MATLAB interface build script to inject Git source/release info via process_keywords, and stop treating .svn as a special directory.

Evidence of the work done

  • Video/figures
    <add video/figures if applicable>
  • Clear from the issue description
  • Not applicable

Tests

  • Tests updated
    <add testcase numbers if applicable, Issue number>
  • Not applicable

Documentation

  • Documentation updated
    <add description of changes if applicable, Issue number>
  • Not applicable

Issue link

…w for three years.

Keep the $HeadURL$ and $Id$ keywords since they are processed by "process_keywords" when building the Delft3D-MATLAB interface distribution.
@hrajagers hrajagers requested a review from a team March 24, 2026 22:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes Subversion-specific revision detection and keyword handling from the QUICKPLOT MATLAB tooling, standardizing revision identification on Git while still supporting $HeadURL$ / $Id$ replacement during distribution builds.

Changes:

  • Remove SVN-based revision detection and internal svnversion implementation from determine_revision.
  • Replace the old svnstripfile behavior with process_keywords that replaces keyword tokens using provided values.
  • Update the Delft3D-MATLAB interface build script to inject Git source/release info via process_keywords, and stop treating .svn as a special directory.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/tools_lgpl/matlab/quickplot/progsrc/private/determine_revision.m Drops SVN logic; uses Git commands to derive hash/repo URL and “(changed)” status.
src/tools_lgpl/matlab/quickplot/process_keywords.m Renames/repurposes keyword processor to replace keyword tokens with provided values.
src/tools_lgpl/matlab/quickplot/make_d3dmatlab.m Uses process_keywords to inject $HeadURL$/$Id$ info into the distribution; removes .svn skipping.
Comments suppressed due to low confidence (1)

src/tools_lgpl/matlab/quickplot/process_keywords.m:6

  • Docstring says this processes only .m, .c, and .cpp files, but the implementation also processes .ini files (see the extension filter below). Please update the docstring to reflect the actual behavior (or drop .ini processing if unintended).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hrajagers hrajagers merged commit 91f2ed6 into main Mar 25, 2026
9 checks passed
@hrajagers hrajagers deleted the task/drop_svn_support branch March 25, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants