Merged
Conversation
…w for three years. Keep the $HeadURL$ and $Id$ keywords since they are processed by "process_keywords" when building the Delft3D-MATLAB interface distribution.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Subversion-specific revision detection and keyword handling from the QUICKPLOT MATLAB tooling, standardizing revision identification on Git while still supporting $HeadURL$ / $Id$ replacement during distribution builds.
Changes:
- Remove SVN-based revision detection and internal
svnversionimplementation fromdetermine_revision. - Replace the old
svnstripfilebehavior withprocess_keywordsthat replaces keyword tokens using provided values. - Update the Delft3D-MATLAB interface build script to inject Git source/release info via
process_keywords, and stop treating.svnas a special directory.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/tools_lgpl/matlab/quickplot/progsrc/private/determine_revision.m |
Drops SVN logic; uses Git commands to derive hash/repo URL and “(changed)” status. |
src/tools_lgpl/matlab/quickplot/process_keywords.m |
Renames/repurposes keyword processor to replace keyword tokens with provided values. |
src/tools_lgpl/matlab/quickplot/make_d3dmatlab.m |
Uses process_keywords to inject $HeadURL$/$Id$ info into the distribution; removes .svn skipping. |
Comments suppressed due to low confidence (1)
src/tools_lgpl/matlab/quickplot/process_keywords.m:6
- Docstring says this processes only
.m,.c, and.cppfiles, but the implementation also processes.inifiles (see the extension filter below). Please update the docstring to reflect the actual behavior (or drop.iniprocessing if unintended).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
V-Chavarrias
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for Subversion revisions since we've been using Git now for three years.
Keep the
$HeadURL$and$Id$keywords since they are processed byprocess_keywordswhen building the Delft3D-MATLAB interface distribution.What was done
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link