Open
Conversation
improve error message for param volume of water in piping
kleijn
requested changes
Apr 17, 2026
| // Stichting Deltares and remain full property of Stichting Deltares at all times. | ||
| // All rights reserved. | ||
|
|
||
| //------------------------------------------------------------------------------ |
Contributor
There was a problem hiding this comment.
Please put back this header
| </data> | ||
| <data name="GeneralPipingInput_WaterVolumetricWeight_must_be_in_Range_0_" xml:space="preserve"> | ||
| <value>De waarde moet binnen het bereik {0} liggen.</value> | ||
| <value>De waarde van volumiek gewicht van water moet binnen het bereik {0} liggen.</value> |
Contributor
There was a problem hiding this comment.
Add this change to the testing notes in the issue?
Contributor
Author
There was a problem hiding this comment.
add it to the testing notes
| TestHelper.AssertThrowsArgumentExceptionAndTestMessage<ArgumentOutOfRangeException>(test, | ||
| "De waarde van asfalt parameter C moet binnen het bereik [0,00, 2,00] liggen."); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Redundant line break
=> Automatically fixed by ReSharper cleanup
| using Core.Gui.Attributes; | ||
| using Riskeer.Common.Forms.PropertyClasses; | ||
| using Riskeer.WaveImpactAsphaltCover.Data; | ||
| using Riskeer.WaveImpactAsphaltCover.Forms.Properties; |
Contributor
There was a problem hiding this comment.
Let's have a look at Riskeer.Piping.Forms.Test.PropertyClasses.CalculationsState.PipingFailureMechanismPropertiesTest for some missing and different tests.
Co-authored-by: Elmar Kleijn <34710209+kleijn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.