fix(svg): gradient number errors read in the reader's house style#185
Merged
Conversation
SvgGradients coordinate/radius/stop parsing now goes through one number() helper that throws '<field> must be a number, got <value>' with the cause chained, matching the rest of the beta SVG reader instead of leaking the raw JDK NumberFormatException. Adds a negative test + CHANGELOG entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the SVG reader error-context work, applied to the gradients path (from #179, already on develop).
SvgGradientscoordinate / radius / stop parsing now goes through onenumber(value, what)helper that throws<field> must be a number, got '<value>'with the cause chained — instead of leaking the raw JDKNumberFormatException("For input string: …"). The reader's per-element wrapper already names the referencing element, so a bad<linearGradient x1="abc">now readsin <path …>: gradient coordinate must be a number, got 'abc'.malformedGradientNumberSaysWhatExpectedANumber.Full suite green (1324).