Conversation
symroe
reviewed
Jun 17, 2025
| .with_post_name("Stroud") | ||
| .with_election_name("Stroud Governace Referendum") | ||
| .with_ballot_paper_id("ref.stroud.2024-11-14") | ||
| .with_election_id("parl.2024-11-14") |
| ballot_title: str = Field() | ||
| poll_open_date: datetime.date = Field() | ||
| elected_role: str = Field() | ||
| elected_role: str = Field(default=None) |
Member
There was a problem hiding this comment.
I think this needs to be Optional[str] to prevent type errors?
Member
Author
There was a problem hiding this comment.
👍 ced00c6
Slightly more generally: For projects like this where we are using types really extensively it would be really useful to look at using something like mypy or pylance in CI to do proper type checks
not today though
Member
There was a problem hiding this comment.
Yeah, I saw Astral have got into this space with ty too
symroe
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows ballots to have a null value for
elected_role, but only if the election type is referendum.This solves one of the problems we have on the EC site.