MaterialTag.sides,snowable,switchable Property Modernization #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmonkey4eva
previously approved these changes
Dec 23, 2024
mcmonkey4eva
changed the title
plugin/src/main/java/com/denizenscript/denizen/scripts/commands/world/SwitchCommand.java
Show resolved
Hide resolved
| return (SculkShrieker) material.getModernData(); | ||
| }*/ | ||
|
|
||
| public boolean getState() { |
There was a problem hiding this comment.
considering getState was used in other code, it should probably be left as-is, same as setState was
| public static final String[] handledMechs = new String[] { | ||
| "snowy" | ||
| }; | ||
| MaterialTag material; |
There was a problem hiding this comment.
This code would produce an error, this value is read from but never set, indicating you didn't actually test this PR.
|
|
||
| public MaterialSides(MaterialTag _material) { | ||
| material = _material; | ||
| // <--[mechanism] |
There was a problem hiding this comment.
this deprecated mech meta is free-floating in a random spot, and the mech isn't registered?
| @@ -152,32 +152,29 @@ public void execute(final ScriptEntry scriptEntry) { | |||
| } | |||
|
|
|||
| public static boolean switchState(Block b) { | |||
| MaterialSwitchable switchable = MaterialSwitchable.getFrom(new MaterialTag(b.getBlockData())); | |||
| if (switchable == null) { | |||
| if (materialTag.getMaterial() == Material.BELL) { | ||
| NMSHandler.blockHelper.ringBell((Bell) block.getState()); | ||
| return; | ||
| } | ||
| boolean currentState = switchable.getState(); |
There was a problem hiding this comment.
see earlier comment re leaving the getState in place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaterialTag.sidesproperty.MaterialTag.snowableproperty.MaterialTag.switchableproperty.