Adds the paper-only dragon egg forms event
#2669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heypr
commented
Nov 1, 2024
•
heypr
commented
- Requested by Ikuria on Discord.
mcmonkey4eva
previously approved these changes
Dec 23, 2024
tal5
reviewed
Dec 27, 2024
| case "location" -> location; | ||
| case "end_portal_location" -> new LocationTag(event.getDragonBattle().getEndPortalLocation()); | ||
| case "previously_killed" -> new ElementTag(event.getDragonBattle().hasBeenPreviouslyKilled()); | ||
| case "respawn_phase" -> new ElementTag(event.getDragonBattle().getRespawnPhase().name()); |
There was a problem hiding this comment.
ElementTag enum constructor - otherwise lgtm
mcmonkey4eva
approved these changes
Feb 9, 2025
tal5
reviewed
Mar 28, 2025
| @EventHandler | ||
| public void onDragonEggForms(DragonEggFormEvent event) { | ||
| location = new LocationTag(event.getBlock().getLocation()); | ||
| entity = new EntityTag(event.getDragonBattle().getEnderDragon()); |
There was a problem hiding this comment.
Ref. Discord may need EntityTag#rememberEntity here - otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.