Support adding/removing multiple resource packs #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| UUID packUUID; | ||
| try { | ||
| packUUID = UUID.fromString(id); | ||
| } catch (IllegalArgumentException e) { |
mcmonkey4eva
previously approved these changes
Mar 24, 2025
|
fixed format |
mcmonkey4eva
approved these changes
Mar 24, 2025
tal5
requested changes
Apr 13, 2025
| Debug.echoDebug(scriptEntry, "Player is offline, can't send resource pack to them. Skipping."); | ||
| continue; | ||
| } | ||
| player.getPlayerEntity().addResourcePack(packUUID, url, hashData, prompt, forced); |
There was a problem hiding this comment.
Using Spigot API here vs Paper API for setting means that set allows advanced text stuff in the prompt and add doesn't - might be better to use Paper API here as well for consistency?
There was a problem hiding this comment.
There isn't a paper api version of this that I saw, other than the Audience stuff. Can you link me what you're referencing?
There was a problem hiding this comment.
Don't think Paper has a direct alternative to the Spigot method? but you can just use adventure, untested but should be something like this:
ResourcePackRequest.Builder builder = ResourcePackRequest.resourcePackRequest();
builder.packs(ResourcePackInfo.resourcePackInfo(UUID.fromString("123"), URI.create("https://www.pack.com/pack.zip"), "hash-13th0aing"));
builder.prompt(Component.text("Use pack pls").color(NamedTextColor.AQUA));
builder.replace(false);
builder.required(true);
player.sendResourcePacks(builder);
Comment on lines
+122
to
+127
| try { | ||
| packUUID = UUID.fromString(id); | ||
| } | ||
| catch (IllegalArgumentException e) { | ||
| packUUID = UUID.nameUUIDFromBytes(id.getBytes(StandardCharsets.UTF_8)); | ||
| } |
There was a problem hiding this comment.
I'd probably put this in a util method on ResourcePackCommand, just because it's repeated a couple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit rusty here so apologies if anything is flat out wrong.
This was all tested on 1.21.4, multiple rps can be added and removals work:
I wasn't sure how to format the command with removals.. my guess is url/hash would become optional args and the meta would need to explain the differences. I just opted for some mecs