Bug fix for villager breeding not being cancellable #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davight
reviewed
Apr 7, 2025
plugin/src/main/java/com/denizenscript/denizen/events/entity/EntityBreedScriptEvent.java
Show resolved
Hide resolved
davight
reviewed
Apr 7, 2025
plugin/src/main/java/com/denizenscript/denizen/events/entity/EntityBreedScriptEvent.java
Show resolved
Hide resolved
mcmonkey4eva
previously approved these changes
Apr 7, 2025
tal5
requested changes
Apr 13, 2025
Comment on lines
42
to
47
| this.<EntityBreedScriptEvent, ElementTag>registerDetermination(null, ElementTag.class, (evt, context, determination) -> { | ||
| if (determination.isInt()) { | ||
| experience = determination.asInt(); | ||
| evt.event.setExperience(experience); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This should be registerOptionalDetermination.
Also there's probably no need for the experience variable vs. just passing determination.asInt() directly?
tal5
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://discord.com/channels/315163488085475337/1352820035067842572