fix: Fixed current streak showing 0 despite having commits today#903
Open
Mahreen-Ahmed wants to merge 2 commits into
Open
fix: Fixed current streak showing 0 despite having commits today#903Mahreen-Ahmed wants to merge 2 commits into
Mahreen-Ahmed wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the request flow in src/index.php to reduce cases where the rendered streak stats are out of date due to the 24-hour cache (notably when a user has committed today but cached stats still show a currentStreak of 0).
Changes:
- Refactors “fetch stats + cache” into a shared
$fetchFreshStatsclosure. - Adds logic to prefer cached stats, but refresh from the GitHub API when the cached
currentStreakappears stale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+73
to
86
| // Check for cached stats first (24 hour cache) unless cache is disabled | ||
| $stats = $useCache ? getCachedStats($user, $cacheOptions) : null; | ||
|
|
||
| if ($stats === null) { | ||
| // No cached stats - fetch fresh data from GitHub API | ||
| $stats = $fetchFreshStats(); | ||
| } elseif ($stats["currentStreak"]["length"] == 0 || $stats["currentStreak"]["end"] != date("Y-m-d")) { | ||
| // Cached streak may be stale - try refreshing, but fall back to cache on failure | ||
| try { | ||
| $stats = $fetchFreshStats(); | ||
| } catch (Exception $e) { | ||
| error_log("Failed to fetch fresh stats for user {$user}: " . $e->getMessage()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Streak shows 0 despite having commits today due to stale cached stats.
Solution
Validate cache freshness before using it. If the streak ends today and has length > 0, use cached data. Otherwise, fetch fresh stats from the GitHub API and update the cache.
Testing
GITHUB_TOKENin.envFixes #896, #902